fix(typing): add missing types to tests and resolve ruff errors

Author: Aitomates

tests/test_api.py

@@ -1,3 +1,4 @@
+from typing import Any
 from unittest.mock import patch
 
 from fastapi.testclient import TestClient
@@ -8,11 +9,11 @@
 
 
 class FailingExternalService:
-    def run(self, envelope) -> str:
+    def run(self: "Any", envelope: "Any") -> str:
         raise WorkflowAgentServiceError("sensitive provider detail")
 
 
-def test_workflow_api_emits_canonical_events(envelope) -> None:
+def test_workflow_api_emits_canonical_events(envelope: "Any") -> None:
     client = TestClient(create_app(Settings()))
 
     response = client.post("/api/v1/workflows", json=envelope.model_dump(mode="json"))
@@ -56,7 +57,7 @@ def test_invalid_foundry_endpoint_is_not_ready() -> None:
     assert client.get("/health/ready").status_code == 503
 
 
-def test_workflow_api_sanitizes_external_service_failures(envelope) -> None:
+def test_workflow_api_sanitizes_external_service_failures(envelope: "Any") -> None:
     with patch(
         "cas_reference_product.app.build_workflow_agent_service",
         return_value=FailingExternalService(),

tests/test_contract_registry.py

@@ -12,7 +12,8 @@
 
 
 def load_json(path: Path) -> dict[str, Any]:
-    return json.loads(path.read_text(encoding="utf-8"))
+    from typing import cast
+    return cast(dict[str, Any], json.loads(path.read_text(encoding="utf-8")))
 
 
 def contract_registry() -> Registry[Any]:
@@ -37,11 +38,11 @@ def test_vendored_contract_release_matches_manifest_hashes() -> None:
         assert hashlib.sha256(content).hexdigest() == entry["sha256"]
 
 
-def test_prompt_envelope_serialization_conforms_to_v010_registry(envelope) -> None:
+def test_prompt_envelope_serialization_conforms_to_v010_registry(envelope: "Any") -> None:
     assert_valid("prompt-envelope.schema.json", envelope.model_dump(mode="json"))
 
 
-def test_run_event_serialization_conforms_to_v010_registry(envelope) -> None:
+def test_run_event_serialization_conforms_to_v010_registry(envelope: "Any") -> None:
     result = WorkflowOrchestrator(LocalWorkflowAgentService(), envelope.repo).execute(envelope)
 
     for event in result.events:

tests/test_function_boundary.py

@@ -1,11 +1,12 @@
+from typing import Any
 import json
 
 import pytest
 
 from cas_reference_product.ingress import InvalidIngressRequest, create_worker_message
 
 
-def test_ingress_validates_and_serializes_canonical_envelope(envelope) -> None:
+def test_ingress_validates_and_serializes_canonical_envelope(envelope: "Any") -> None:
     message = create_worker_message(envelope.model_dump_json().encode())
 
     assert json.loads(message)["runId"] == envelope.runId

tests/test_models.py

@@ -1,18 +1,19 @@
+from typing import Any
 import pytest
 from pydantic import ValidationError
 
 from cas_reference_product.models import Actor, PromptEnvelope, RunEvent, TraceContext
 
 
-def test_prompt_envelope_rejects_extra_properties(envelope) -> None:
+def test_prompt_envelope_rejects_extra_properties(envelope: "Any") -> None:
     payload = envelope.model_dump()
     payload["secret"] = "not-allowed"
 
     with pytest.raises(ValidationError):
         PromptEnvelope.model_validate(payload)
 
 
-def test_prompt_envelope_matches_cas_contract_metadata(envelope) -> None:
+def test_prompt_envelope_matches_cas_contract_metadata(envelope: "Any") -> None:
     payload = envelope.model_dump(mode="json")
 
     assert payload["kind"] == "PromptEnvelope"
@@ -28,7 +29,7 @@ def test_prompt_envelope_matches_cas_contract_metadata(envelope) -> None:
         ["No secrets", "No secrets"],
     ],
 )
-def test_prompt_envelope_enforces_cas_contract_constraints(envelope, constraints) -> None:
+def test_prompt_envelope_enforces_cas_contract_constraints(envelope: "Any", constraints: "Any") -> None:
     payload = envelope.model_dump()
     payload["constraints"] = constraints
 
@@ -67,6 +68,6 @@ def test_prompt_envelope_enforces_cas_contract_constraints(envelope, constraints
         ),
     ],
 )
-def test_contract_models_reject_explicit_null_optional_fields(model, payload) -> None:
+def test_contract_models_reject_explicit_null_optional_fields(model: "Any", payload: "Any") -> None:
     with pytest.raises(ValidationError):
         model.model_validate(payload)

tests/test_service_factory.py

@@ -1,3 +1,4 @@
+from typing import Any
 from unittest.mock import patch
 
 import pytest
@@ -39,7 +40,7 @@ def test_foundry_service_rejects_invalid_project_endpoint() -> None:
         FoundryWorkflowAgentService(settings)
 
 
-def test_foundry_service_uses_next_gen_agent_reference(envelope) -> None:
+def test_foundry_service_uses_next_gen_agent_reference(envelope: "Any") -> None:
     settings = Settings(
         environment="prod",
         workflow_backend="foundry",
@@ -71,7 +72,7 @@ def test_foundry_service_uses_next_gen_agent_reference(envelope) -> None:
     assert result == "Foundry result"
 
 
-def test_foundry_service_sanitizes_sdk_failure(envelope) -> None:
+def test_foundry_service_sanitizes_sdk_failure(envelope: "Any") -> None:
     settings = Settings(
         environment="prod",
         workflow_backend="foundry",

tests/test_telemetry.py

@@ -1,3 +1,4 @@
+from typing import Any
 """Tests for Phase 2 — Telemetry Hardening (TEL-01 through TEL-04)."""
 
 from unittest.mock import MagicMock, patch
@@ -110,12 +111,13 @@ def test_all_loop_stages_share_one_trace_without_prompt_or_output_attributes() -
                     pass
 
     spans = exporter.get_finished_spans()
-    assert {span.attributes["cas.stage"] for span in spans} == {stage.value for stage in LoopStage}
+    stage_values = {stage.value for stage in LoopStage}
+    assert {span.attributes["cas.stage"] for span in spans if span.attributes} == stage_values
     assert len({span.context.trace_id for span in spans}) == 1
     assert all(
         "prompt" not in key and "output" not in key
         for span in spans
-        for key in span.attributes
+        for key in (span.attributes or {})
     )
 
 
@@ -140,7 +142,7 @@ def test_install_propagator_sets_w3c_propagator() -> None:
 # ---------------------------------------------------------------------------
 
 
-def test_workflow_endpoint_creates_span(in_memory_exporter: InMemorySpanExporter, envelope) -> None:
+def test_workflow_endpoint_creates_span(in_memory_exporter: InMemorySpanExporter, envelope: "Any") -> None:
     client = TestClient(create_app(Settings()))
     response = client.post("/api/v1/workflows", json=envelope.model_dump(mode="json"))
 
@@ -157,12 +159,13 @@ def test_workflow_endpoint_creates_span(in_memory_exporter: InMemorySpanExporter
 # ---------------------------------------------------------------------------
 
 
-def test_workflow_span_attributes(in_memory_exporter: InMemorySpanExporter, envelope) -> None:
+def test_workflow_span_attributes(in_memory_exporter: InMemorySpanExporter, envelope: "Any") -> None:
     client = TestClient(create_app(Settings()))
     client.post("/api/v1/workflows", json=envelope.model_dump(mode="json"))
 
     spans = in_memory_exporter.get_finished_spans()
     api_span = next(s for s in spans if s.name == "cas.api.workflows.execute")
+    assert api_span.attributes
     assert api_span.attributes.get("cas.correlation_id") == envelope.correlationId
     assert api_span.attributes.get("cas.run_id") == envelope.runId
     assert api_span.attributes.get("cas.intent") == envelope.intent
@@ -174,7 +177,7 @@ def test_workflow_span_attributes(in_memory_exporter: InMemorySpanExporter, enve
 
 
 def test_workflow_span_events_started_and_completed(
-    in_memory_exporter: InMemorySpanExporter, envelope
+    in_memory_exporter: InMemorySpanExporter, envelope: "Any"
 ) -> None:
     client = TestClient(create_app(Settings()))
     client.post("/api/v1/workflows", json=envelope.model_dump(mode="json"))
@@ -188,12 +191,12 @@ def test_workflow_span_events_started_and_completed(
 
 
 def test_workflow_span_events_started_and_failed(
-    in_memory_exporter: InMemorySpanExporter, envelope
+    in_memory_exporter: InMemorySpanExporter, envelope: "Any"
 ) -> None:
     from cas_reference_product.workflow import WorkflowAgentServiceError
 
     class FailingService:
-        def run(self, _env) -> str:
+        def run(self: "Any", _env: "Any") -> str:
             raise WorkflowAgentServiceError("backend down")
 
     with patch(
@@ -213,14 +216,15 @@ def run(self, _env) -> str:
 
 
 def test_span_event_carries_correlation_id(
-    in_memory_exporter: InMemorySpanExporter, envelope
+    in_memory_exporter: InMemorySpanExporter, envelope: "Any"
 ) -> None:
     client = TestClient(create_app(Settings()))
     client.post("/api/v1/workflows", json=envelope.model_dump(mode="json"))
 
     spans = in_memory_exporter.get_finished_spans()
     api_span = next(s for s in spans if s.name == "cas.api.workflows.execute")
     started_event = next(e for e in api_span.events if e.name == "workflow.started")
+    assert started_event.attributes
     assert started_event.attributes.get("cas.correlation_id") == envelope.correlationId
     assert started_event.attributes.get("cas.run_id") == envelope.runId
 
@@ -231,7 +235,7 @@ def test_span_event_carries_correlation_id(
 
 
 def test_w3c_traceparent_propagated_inbound(
-    in_memory_exporter: InMemorySpanExporter, envelope
+    in_memory_exporter: InMemorySpanExporter, envelope: "Any"
 ) -> None:
     """Request with a W3C traceparent header links the API span as a child."""
     incoming_traceparent = "00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01"

tests/test_workflow.py

@@ -1,3 +1,4 @@
+from typing import Any
 from datetime import UTC, datetime
 from unittest.mock import patch
 
@@ -7,16 +8,16 @@
 
 
 class SuccessfulService:
-    def run(self, envelope) -> str:
+    def run(self: "Any", envelope: "Any") -> str:
         return f"processed:{envelope.promptId}"
 
 
 class FailingService:
-    def run(self, envelope) -> str:
+    def run(self: "Any", envelope: "Any") -> str:
         raise RuntimeError("expected")
 
 
-def test_orchestrator_returns_traceable_events(envelope) -> None:
+def test_orchestrator_returns_traceable_events(envelope: "Any") -> None:
     fixed = datetime(2026, 6, 11, 10, 0, tzinfo=UTC)
     # Patch current_traceparent so this unit test is provider-independent.
     with patch(
@@ -36,6 +37,6 @@ def test_orchestrator_returns_traceable_events(envelope) -> None:
     assert all(event.traceContext == envelope.traceContext for event in result.events)
 
 
-def test_orchestrator_propagates_failure(envelope) -> None:
+def test_orchestrator_propagates_failure(envelope: "Any") -> None:
     with pytest.raises(RuntimeError, match="expected"):
         WorkflowOrchestrator(FailingService(), envelope.repo).execute(envelope)