fix(readiness): resolve F-06 validate Foundry configuration

Author: Aitomates

src/cas_reference_product/config.py

@@ -1,4 +1,5 @@
 from functools import lru_cache
+import re
 from typing import Literal
 
 from pydantic import Field
@@ -17,11 +18,21 @@ class Settings(BaseSettings):
     applicationinsights_connection_string: str | None = Field(default=None, repr=False)
 
     @property
-    def ready(self) -> bool:
-        return self.workflow_backend == "local" or bool(
-            self.foundry_project_endpoint and self.foundry_agent_name
+    def foundry_ready(self) -> bool:
+        return bool(
+            self.foundry_project_endpoint
+            and re.fullmatch(
+                r"https://[A-Za-z0-9.-]+\.services\.ai\.azure\.com/api/projects/[A-Za-z0-9_.-]+/?",
+                self.foundry_project_endpoint,
+            )
+            and self.foundry_agent_name
+            and self.foundry_agent_name.strip()
         )
 
+    @property
+    def ready(self) -> bool:
+        return self.workflow_backend == "local" or self.foundry_ready
+
 
 @lru_cache
 def get_settings() -> Settings:

src/cas_reference_product/workflow.py

@@ -36,8 +36,10 @@ class FoundryWorkflowAgentService:
     """Invoke a Foundry Next Gen agent reference through the project Responses client."""
 
     def __init__(self, settings: Settings) -> None:
-        if not settings.foundry_project_endpoint or not settings.foundry_agent_name:
-            raise ValueError("Foundry backend requires project endpoint and agent name")
+        if not settings.foundry_ready:
+            raise ValueError("Foundry backend requires a valid project endpoint and agent name")
+        assert settings.foundry_project_endpoint is not None
+        assert settings.foundry_agent_name is not None
         self._agent_name = settings.foundry_agent_name
         self._client = AIProjectClient(
             endpoint=settings.foundry_project_endpoint,

tests/test_api.py

@@ -41,6 +41,21 @@ def test_incomplete_foundry_configuration_is_not_ready() -> None:
     assert client.post("/api/v1/workflows", json={}).status_code == 422
 
 
+def test_invalid_foundry_endpoint_is_not_ready() -> None:
+    client = TestClient(
+        create_app(
+            Settings(
+                workflow_backend="foundry",
+                foundry_project_endpoint="https://example.invalid/project",
+                foundry_agent_name="cas-reference-agent",
+            )
+        )
+    )
+
+    assert client.get("/health/live").status_code == 200
+    assert client.get("/health/ready").status_code == 503
+
+
 def test_workflow_api_sanitizes_external_service_failures(envelope) -> None:
     with patch(
         "cas_reference_product.app.build_workflow_agent_service",

tests/test_service_factory.py

@@ -27,6 +27,18 @@ def test_factory_builds_foundry_service_when_configured() -> None:
     service.assert_called_once_with(settings)
 
 
+def test_foundry_service_rejects_invalid_project_endpoint() -> None:
+    settings = Settings(
+        environment="prod",
+        workflow_backend="foundry",
+        foundry_project_endpoint="https://example.invalid/project",
+        foundry_agent_name="cas-reference-agent",
+    )
+
+    with pytest.raises(ValueError, match="valid project endpoint"):
+        FoundryWorkflowAgentService(settings)
+
+
 def test_foundry_service_uses_next_gen_agent_reference(envelope) -> None:
     settings = Settings(
         environment="prod",