test(gsd-orchestrator): land coverage suite, multi-machine orchestration, and contract fixes - #15
test(gsd-orchestrator): land coverage suite, multi-machine orchestration, and contract fixes#15OgeonX-Ai wants to merge 0 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afa28ab55a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| [xml]$xml = Get-Content $file.FullName | ||
| $rate = [double]$xml.coverage.'line-rate' | ||
| if ($rate -lt 1.0) { |
There was a problem hiding this comment.
Relax the 100% coverage gate until coverage reaches it
In this workflow the full test project runs with coverlet and then exits on any line-rate below 1.0. The repository's current coverage artifacts report line rates around 0.9365/0.9395, and this commit also adds uncovered ApiGoalStore/ApiNodeRegistry code without tests or exclusions, so the CI job will fail even when all tests pass. Please lower the threshold or add the missing coverage/exclusions before making this a required gate.
Useful? React with 👍 / 👎.
775b8f1 to
a01b130
Compare
Summary
.gitignoreTestResults, CI updates) and hardens workflow permissions/timeouts acrossci.yml,codeql.yml,pages.yml,pr-lint.yml,stale.ymlApiGoalStore,ApiNodeRegistry,INodeRegistry,NodeSettings,GoalSchedulerupdates)31 files changed, +626/-37.
Part of the Phase 30 release train (
.planning/phases/30-release-train-and-branch-hygiene/).Note: This branch touches
.github/workflows/ci.yml, which also changed in dependabot PR #13. Merge #13 first, then rungh pr update-branchon this PR before merging, keeping both the bumped action versions (from #13) and the coverage/test changes (from this branch).🤖 Generated with Claude Code