Skip to content

test(gsd-orchestrator): land coverage suite, multi-machine orchestration, and contract fixes - #15

Closed
OgeonX-Ai wants to merge 0 commit into
mainfrom
ci/dependabot-github-actions
Closed

test(gsd-orchestrator): land coverage suite, multi-machine orchestration, and contract fixes#15
OgeonX-Ai wants to merge 0 commit into
mainfrom
ci/dependabot-github-actions

Conversation

@OgeonX-Ai

Copy link
Copy Markdown
Contributor

Summary

  • Adds/tracks the gsd-orchestrator test suite (.gitignore TestResults, CI updates) and hardens workflow permissions/timeouts across ci.yml, codeql.yml, pages.yml, pr-lint.yml, stale.yml
  • Implements Multi-Machine Orchestration Core (ApiGoalStore, ApiNodeRegistry, INodeRegistry, NodeSettings, GoalScheduler updates)
  • Fixes contract digest comparisons, canonicalizes release bytes as LF, pins canonical v1.1.1 release, and verifies published registry drift
  • Adds dependabot github-actions updates config

31 files changed, +626/-37.

Part of the Phase 30 release train (.planning/phases/30-release-train-and-branch-hygiene/).

Note: This branch touches .github/workflows/ci.yml, which also changed in dependabot PR #13. Merge #13 first, then run gh pr update-branch on this PR before merging, keeping both the bumped action versions (from #13) and the coverage/test changes (from this branch).

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: afa28ab55a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml Outdated
}
[xml]$xml = Get-Content $file.FullName
$rate = [double]$xml.coverage.'line-rate'
if ($rate -lt 1.0) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Relax the 100% coverage gate until coverage reaches it

In this workflow the full test project runs with coverlet and then exits on any line-rate below 1.0. The repository's current coverage artifacts report line rates around 0.9365/0.9395, and this commit also adds uncovered ApiGoalStore/ApiNodeRegistry code without tests or exclusions, so the CI job will fail even when all tests pass. Please lower the threshold or add the missing coverage/exclusions before making this a required gate.

Useful? React with 👍 / 👎.

@OgeonX-Ai OgeonX-Ai closed this Jul 6, 2026
@OgeonX-Ai
OgeonX-Ai force-pushed the ci/dependabot-github-actions branch from 775b8f1 to a01b130 Compare July 6, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant