Add toggle to disable chat auto-open on activity (SubnauticaNitrox#2650)

Author: misterbubb

NitroxClient/Communication/Packets/Processors/ChatMessageProcessor.cs

@@ -64,7 +64,7 @@ private void LogClientMessage(ChatMessage message)
             }
 
             playerChatManager.AddMessage(playerName, message.Text, color.ToUnity());
-            if (NitroxPrefs.ChatVisibilityDuration.Value > 0f)
+            if (NitroxPrefs.ChatAutoOpen.Value)
             {
                 playerChatManager.ShowChat();
             }
@@ -73,7 +73,7 @@ private void LogClientMessage(ChatMessage message)
         private void LogServerMessage(ChatMessage message)
         {
             playerChatManager.AddMessage("Server", message.Text, serverMessageColor);
-            if (NitroxPrefs.ChatVisibilityDuration.Value > 0f)
+            if (NitroxPrefs.ChatAutoOpen.Value)
             {
                 playerChatManager.ShowChat();
             }

NitroxClient/GameLogic/Settings/NitroxPrefs.cs

@@ -10,9 +10,12 @@ public class NitroxPrefs
         public static readonly NitroxPref<bool> HideIp = new("Nitrox.hideIp");
         /// <summary>
         /// How long the chat window stays visible after receiving a message (in seconds).
-        /// 0 = chat is disabled (won't show when others chat).
         /// </summary>
         public static readonly NitroxPref<float> ChatVisibilityDuration = new("Nitrox.chatVisibilityDuration", 6f);
+        /// <summary>
+        /// Whether the chat window should automatically open when receiving messages.
+        /// </summary>
+        public static readonly NitroxPref<bool> ChatAutoOpen = new("Nitrox.chatAutoOpen", true);
         public static readonly NitroxPref<bool> ChatUsed = new("Nitrox.chatUsed");
         public static readonly NitroxPref<bool> SafeBuilding = new("Nitrox.safeBuilding", true);
         public static readonly NitroxPref<bool> SafeBuildingLog = new("Nitrox.safeBuildingLog", true);

NitroxClient/GameLogic/Settings/NitroxSettingsManager.cs

@@ -34,7 +34,8 @@ public NitroxSettingsManager()
     /// </summary>
     private void MakeSettings()
     {
-        AddSetting("Nitrox_Settings_Privacy", new Setting("Nitrox_Settings_ChatVisibilityDuration", NitroxPrefs.ChatVisibilityDuration, duration => NitroxPrefs.ChatVisibilityDuration.Value = (int)duration, 0f, 15f, NitroxPrefs.ChatVisibilityDuration.DefaultValue, 1f, SliderLabelMode.Int, "0", "Nitrox_Settings_ChatVisibilityDuration_Tooltip"));
+        AddSetting("Nitrox_Settings_Privacy", new Setting("Nitrox_Settings_ChatAutoOpen", NitroxPrefs.ChatAutoOpen, autoOpen => NitroxPrefs.ChatAutoOpen.Value = autoOpen));
+        AddSetting("Nitrox_Settings_Privacy", new Setting("Nitrox_Settings_ChatVisibilityDuration", NitroxPrefs.ChatVisibilityDuration, duration => NitroxPrefs.ChatVisibilityDuration.Value = (int)duration, 1f, 15f, NitroxPrefs.ChatVisibilityDuration.DefaultValue, 1f, SliderLabelMode.Int, "0", "Nitrox_Settings_ChatVisibilityDuration_Tooltip"));
         AddSetting("Nitrox_Settings_Privacy", new Setting("Nitrox_HideIp", NitroxPrefs.HideIp, hide =>
         {
             NitroxPrefs.HideIp.Value = hide;

NitroxClient/MonoBehaviours/Gui/Chat/PlayerChat.cs

@@ -3,7 +3,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using NitroxClient.GameLogic.ChatUI;
-using NitroxClient.GameLogic.Settings;
 using UnityEngine;
 using UnityEngine.UI;
 
@@ -53,10 +52,6 @@ public IEnumerator SetupChatComponents()
 
             yield return new WaitForEndOfFrame(); //Needed so Select() works on initialization
             IsReady = true;
-            if (NitroxPrefs.ChatVisibilityDuration.Value <= 0f)
-            {
-                Log.InGame(Language.main.Get("Nitrox_SilencedChatNotif"));
-            }
         }
 
         public IEnumerator WriteLogEntry(string playerName, string message, Color color)

NitroxClient/MonoBehaviours/Gui/Chat/PlayerChatInputField.cs

@@ -71,7 +71,7 @@ public static void ResetTimer()
         {
             float duration = NitroxPrefs.ChatVisibilityDuration.Value;
             timeLeftUntilAutoClose = duration;
-            // Unfreeze time so the countdown can start (unless duration is 0, which means chat is disabled)
+            // Unfreeze time so the countdown can start
             FreezeTime = false;
         }
 

NitroxClient/MonoBehaviours/Gui/Input/KeyBindings/Actions/ChatKeyBindingAction.cs

@@ -1,5 +1,4 @@
 using NitroxClient.GameLogic.ChatUI;
-using NitroxClient.GameLogic.Settings;
 using UnityEngine.InputSystem;
 
 namespace NitroxClient.MonoBehaviours.Gui.Input.KeyBindings.Actions;
@@ -10,12 +9,6 @@ public ChatKeyBindingAction() : base("Nitrox_Settings_Keybind_OpenChat", "y") {
 
     public override void Execute(InputAction.CallbackContext _)
     {
-        // If slider is at 0, chat is completely disabled
-        if (NitroxPrefs.ChatVisibilityDuration.Value <= 0f)
-        {
-            return;
-        }
-
         // If no other UWE input field is currently active then allow chat to open.
         if (FPSInputModule.current.lastGroup == null && Multiplayer.Joined)
         {