Merge branch 'main' of https://github.com/CodingAleCR/http_interceptor

Author: CodingAleCR

.all-contributorsrc

@@ -102,6 +102,25 @@
       "contributions": [
         "ideas"
       ]
+    },
+    {
+      "login": "meysammahfouzi",
+      "name": "Meysam",
+      "avatar_url": "https://avatars.githubusercontent.com/u/14848008?v=4",
+      "profile": "https://github.com/meysammahfouzi",
+      "contributions": [
+        "doc"
+      ]
+    },
+    {
+      "login": "Mawi137",
+      "name": "Martijn",
+      "avatar_url": "https://avatars.githubusercontent.com/u/5464100?v=4",
+      "profile": "https://github.com/Mawi137",
+      "contributions": [
+        "test",
+        "code"
+      ]
     }
   ],
   "contributorsPerLine": 7,

CHANGELOG.md

@@ -1,23 +1,17 @@
 # Changelog
 
-## Unreleased
-
-- ✨  Added: Response Transformation (useful for background json decoding/encoding).
-- ✨  Added: Support for streamed requests and `send` method.
-- ✨  Changed: 80% code coverage.
-
 ## 1.0.0
 
+Check out the [1.0.0 migration guide](./guides/migration_guide_1.0.0.md) for information on how to migrate your code.
+
 - ❗️🛠  Changed: Renamed `HttpClientWithInterceptor` to `InterceptedClient`.
 - ❗️🛠  Changed: Renamed `HttpWithInterceptor` to `InterceptedHttp`.
 - ❗️🛠  Removed: `badCertificateCallback` from `InterceptedClient` and `InterceptedHttp` in order to fully support Flutter Web 🌐 . In order to use refer to the migration guide.
 - ✨  Added: Array parameters on `RequestData` following a similar principle than `http`'s `queryParametersAll` .
 - ✨  Changed: `ResponseData` now has `bodyBytes` to allow encoding or decoding in the format desired.
 - ✨  Changed: Migrated tests to use `test` package instead of `flutter_test`.
-- ✨  Changed: Package no longer depends on Flutter, which means that it can be used with standalone Dart projects.
 - ✨  Changed: More tests and coverage, this is a work in progress.
-
-Check out the [1.0.0 migration guide](./guides/migration_guide_1.0.0.md) for information on how to migrate your code.
+- 🗑  Removed: Package no longer depends on Flutter, which means that it can be used with standalone Dart projects.
 
 ## 0.4.1
 

README.md

@@ -3,13 +3,13 @@
 [![Pub](https://img.shields.io/pub/v/http_interceptor.svg)](https://pub.dev/packages/http_interceptor)
 [![style: effective dart](https://img.shields.io/badge/style-effective_dart-40c4ff.svg)](https://github.com/tenhobi/effective_dart)
 [![License: MIT](https://img.shields.io/badge/license-MIT-purple.svg)](https://opensource.org/licenses/MIT)
-[![codecov](https://codecov.io/gh/CodingAleCR/http_interceptor/branch/master/graph/badge.svg)](https://codecov.io/gh/CodingAleCR/http_interceptor)
+[![codecov](https://codecov.io/gh/CodingAleCR/http_interceptor/branch/main/graph/badge.svg?token=hgsnPctaDz)](https://codecov.io/gh/CodingAleCR/http_interceptor)
 [![Star on GitHub](https://img.shields.io/github/stars/codingalecr/http_interceptor.svg?style=flat&logo=github&colorB=deeppink&label=stars)](https://github.com/codingalecr/http_interceptor)
 
 <!-- prettier-ignore-start -->
 <!-- markdownlint-disable -->
 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[![All Contributors](https://img.shields.io/badge/all_contributors-9-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-11-orange.svg?style=flat-square)](#contributors-)
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 <!-- markdownlint-restore -->
 <!-- prettier-ignore-end -->
@@ -65,13 +65,13 @@ In order to implement `http_interceptor` you need to implement the `InterceptorC
 ```dart
 class LoggingInterceptor implements InterceptorContract {
   @override
-  Future<RequestData> interceptRequest({RequestData data}) async {
+  Future<RequestData> interceptRequest({required RequestData data}) async {
     print(data.toString());
     return data;
   }
 
   @override
-  Future<ResponseData> interceptResponse({ResponseData data}) async {
+  Future<ResponseData> interceptResponse({required ResponseData data}) async {
       print(data.toString());
       return data;
   }
@@ -84,7 +84,7 @@ class LoggingInterceptor implements InterceptorContract {
 ```dart
 class WeatherApiInterceptor implements InterceptorContract {
   @override
-  Future<RequestData> interceptRequest({RequestData data}) async {
+  Future<RequestData> interceptRequest({required RequestData data}) async {
     try {
       data.params['appid'] = OPEN_WEATHER_API_KEY;
       data.params['units'] = 'metric';
@@ -96,7 +96,7 @@ class WeatherApiInterceptor implements InterceptorContract {
   }
 
   @override
-  Future<ResponseData> interceptResponse({ResponseData data}) async => data;
+  Future<ResponseData> interceptResponse({required ResponseData data}) async => data;
 }
 ```
 
@@ -265,6 +265,8 @@ Thanks to all the wonderful people contributing to improve this package. Check t
   <tr>
     <td align="center"><a href="https://github.com/shyndman"><img src="https://avatars.githubusercontent.com/u/42326?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Scott Hyndman</b></sub></a><br /><a href="#ideas-shyndman" title="Ideas, Planning, & Feedback">🤔</a></td>
     <td align="center"><a href="https://github.com/II11II"><img src="https://avatars.githubusercontent.com/u/45257709?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Islam Akhrarov</b></sub></a><br /><a href="#ideas-II11II" title="Ideas, Planning, & Feedback">🤔</a></td>
+    <td align="center"><a href="https://github.com/meysammahfouzi"><img src="https://avatars.githubusercontent.com/u/14848008?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Meysam</b></sub></a><br /><a href="https://github.com/CodingAleCR/http_interceptor/commits?author=meysammahfouzi" title="Documentation">📖</a></td>
+    <td align="center"><a href="https://github.com/Mawi137"><img src="https://avatars.githubusercontent.com/u/5464100?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Martijn</b></sub></a><br /><a href="https://github.com/CodingAleCR/http_interceptor/commits?author=Mawi137" title="Tests">⚠️</a> <a href="https://github.com/CodingAleCR/http_interceptor/commits?author=Mawi137" title="Code">💻</a></td>
   </tr>
 </table>
 

lib/models/request_data.dart

@@ -27,7 +27,7 @@ class RequestData {
 
   factory RequestData.fromHttpRequest(Request request) {
     var params = Map<String, dynamic>();
-    request.url.queryParameters.forEach((key, value) {
+    request.url.queryParametersAll.forEach((key, value) {
       params[key] = value;
     });
     String baseUrl = request.url.origin + request.url.path;

test/models/request_data_test.dart

@@ -67,6 +67,23 @@ main() {
           equals(
               "https://www.google.com/helloworld?key=123ABC&name=Hugo&type=3"));
     });
+    test("can be instantiated from HTTP GET Request with multiple parameters with same key", () {
+      // Arrange
+      Uri url = Uri.parse(
+          "https://www.google.com/helloworld?name=Hugo&type=2&type=3&type=4");
+
+      Request request = Request("GET", url);
+      RequestData requestData;
+
+      // Act
+      requestData = RequestData.fromHttpRequest(request);
+
+      // Assert
+      expect(
+          requestData.url,
+          equals(
+              "https://www.google.com/helloworld?name=Hugo&type=2&type=3&type=4"));
+    });
     test("correctly creates the request URL string", () {
       // Arrange
       Uri url = Uri.parse(