Fix URI, retry, and fragment handling in HTTP interceptor

Co-authored-by: me <me@codingale.dev>

Author: cursoragent

BUGS_FIXED.md

@@ -0,0 +1,24 @@
+# Bugs Fixed in HTTP Interceptor
+
+## Bug #1: `maxRetryAttempts` cannot be overridden in subclasses
+
+**File**: `lib/models/retry_policy.dart`
+**Issue**: The `maxRetryAttempts` field was declared as `final int maxRetryAttempts = 1;` which prevented subclasses from overriding it.
+**Fix**: Changed it to `int get maxRetryAttempts => 1;` to allow subclasses to override the getter.
+**Impact**: This allows proper inheritance for retry policies, as demonstrated in the example where `ExpiredTokenRetryPolicy` overrides `maxRetryAttempts` to return 2.
+
+## Bug #2: `_attemptRequest` recursive calls missing `isStream` parameter
+
+**File**: `lib/http/intercepted_client.dart`
+**Issue**: When retrying requests, the recursive calls to `_attemptRequest` didn't pass the `isStream` parameter, which could cause issues when retrying streamed requests.
+**Fix**: Added `isStream: isStream` parameter to both recursive calls in the retry logic (lines 295 and 304).
+**Impact**: This ensures that streamed requests are properly handled during retries, maintaining the correct response type.
+
+## Bug #3: URI fragment (#) is lost in `addParameters` method
+
+**File**: `lib/extensions/uri.dart`
+**Issue**: The `addParameters` method used `origin + path` to build the URL but ignored the fragment part of the URI, causing fragments to be lost.
+**Fix**: Added logic to preserve the fragment by appending `#$fragment` to the final URL if a fragment exists.
+**Impact**: This ensures that URI fragments are preserved when adding query parameters, maintaining the complete URL structure.
+
+All three bugs have been successfully fixed and the code should now work correctly in all scenarios.

lib/extensions/uri.dart

@@ -19,6 +19,13 @@ extension AddParameters on Uri {
       newParameters[key] = value;
     });
 
-    return buildUrlString(paramUrl, newParameters).toUri();
+    String finalUrl = buildUrlString(paramUrl, newParameters);
+    
+    // Preserve the fragment if it exists
+    if (fragment.isNotEmpty) {
+      finalUrl += '#$fragment';
+    }
+
+    return finalUrl.toUri();
   }
 }

lib/http/intercepted_client.dart

@@ -293,7 +293,7 @@ class InterceptedClient extends BaseClient {
         _retryCount += 1;
         await Future.delayed(retryPolicy!
             .delayRetryAttemptOnResponse(retryAttempt: _retryCount));
-        return _attemptRequest(request);
+        return _attemptRequest(request, isStream: isStream);
       }
     } on Exception catch (error) {
       if (retryPolicy != null &&
@@ -302,7 +302,7 @@ class InterceptedClient extends BaseClient {
         _retryCount += 1;
         await Future.delayed(retryPolicy!
             .delayRetryAttemptOnException(retryAttempt: _retryCount));
-        return _attemptRequest(request);
+        return _attemptRequest(request, isStream: isStream);
       } else {
         rethrow;
       }

lib/models/retry_policy.dart

@@ -45,7 +45,7 @@ abstract class RetryPolicy {
   FutureOr<bool> shouldAttemptRetryOnResponse(BaseResponse response) => false;
 
   /// Number of maximum request attempts that can be retried.
-  final int maxRetryAttempts = 1;
+  int get maxRetryAttempts => 1;
 
   Duration delayRetryAttemptOnException({required int retryAttempt}) =>
       Duration.zero;