fix: dedupe fetchWithTimeout/sleep into rpc.ts, rename infographicPath → infographicUrl

Review fixes from @pm:
1. Moved fetchWithTimeout() and sleep() to rpc.ts as shared exports
2. Removed duplicates from auth.ts, client.ts, and research.ts
3. Renamed infographicPath → infographicUrl in ResearchPayload and ingest route

Co-authored-by: research <research@miriad.systems>

Author: Miriad

app/api/cron/ingest/route.ts

@@ -152,7 +152,7 @@ function buildPrompt(trends: TrendResult[], research?: ResearchPayload): string
 			}
 		}
 
-		if (research.infographicPath) {
+		if (research.infographicUrl) {
 			researchContext += `\n### Infographic Available\nAn infographic has been generated for this topic. Use sceneType "narration" with bRollUrl pointing to the infographic for at least one scene.\n`;
 		}
 	}

lib/services/notebooklm/auth.ts

@@ -9,6 +9,7 @@
  */
 
 import type { AuthTokens, NotebookLMCookie } from './types';
+import { fetchWithTimeout } from './rpc';
 
 // ---------------------------------------------------------------------------
 // Constants
@@ -107,28 +108,6 @@ function buildCookieHeader(cookies: Record<string, string>): string {
     .join('; ');
 }
 
-/**
- * Fetch with an AbortController timeout.
- */
-async function fetchWithTimeout(
-  url: string,
-  init: RequestInit,
-  timeoutMs: number
-): Promise<Response> {
-  const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), timeoutMs);
-
-  try {
-    const response = await fetch(url, {
-      ...init,
-      signal: controller.signal,
-    });
-    return response;
-  } finally {
-    clearTimeout(timer);
-  }
-}
-
 // ---------------------------------------------------------------------------
 // Main auth function
 // ---------------------------------------------------------------------------

lib/services/notebooklm/client.ts

@@ -26,6 +26,8 @@ import {
   buildRpcUrl,
   decodeResponse,
   NotebookLMRPCError,
+  fetchWithTimeout,
+  sleep,
 } from './rpc';
 import { initAuth } from './auth';
 
@@ -46,28 +48,6 @@ const DEFAULT_SOURCE_PATH = '/';
 // Helpers
 // ---------------------------------------------------------------------------
 
-/**
- * Fetch with AbortController timeout.
- */
-async function fetchWithTimeout(
-  url: string,
-  init: RequestInit,
-  timeoutMs: number
-): Promise<Response> {
-  const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), timeoutMs);
-
-  try {
-    const response = await fetch(url, {
-      ...init,
-      signal: controller.signal,
-    });
-    return response;
-  } finally {
-    clearTimeout(timer);
-  }
-}
-
 /**
  * Check if a URL is a YouTube URL.
  */
@@ -76,13 +56,6 @@ function isYouTubeUrl(url: string): boolean {
   return lower.includes('youtube.com') || lower.includes('youtu.be');
 }
 
-/**
- * Sleep for a given number of milliseconds.
- */
-function sleep(ms: number): Promise<void> {
-  return new Promise((resolve) => setTimeout(resolve, ms));
-}
-
 /**
  * Safely access a deeply nested array value.
  * Returns undefined if any intermediate access fails.

lib/services/notebooklm/rpc.ts

@@ -228,3 +228,36 @@ export function decodeResponse(
 
   return extractRpcResult(chunks, rpcId);
 }
+
+// ---------------------------------------------------------------------------
+// Shared utilities (used by auth.ts, client.ts, research.ts)
+// ---------------------------------------------------------------------------
+
+/**
+ * Fetch with an AbortController timeout.
+ */
+export async function fetchWithTimeout(
+  url: string,
+  init: RequestInit,
+  timeoutMs: number
+): Promise<Response> {
+  const controller = new AbortController();
+  const timer = setTimeout(() => controller.abort(), timeoutMs);
+
+  try {
+    const response = await fetch(url, {
+      ...init,
+      signal: controller.signal,
+    });
+    return response;
+  } finally {
+    clearTimeout(timer);
+  }
+}
+
+/**
+ * Sleep for a given number of milliseconds.
+ */
+export function sleep(ms: number): Promise<void> {
+  return new Promise((resolve) => setTimeout(resolve, ms));
+}

lib/services/research.ts

@@ -11,6 +11,7 @@
  */
 
 import { NotebookLMClient } from './notebooklm/client';
+import { sleep } from './notebooklm/rpc';
 
 // ---------------------------------------------------------------------------
 // Types (kept identical for backward compatibility with ingest route)
@@ -32,7 +33,7 @@ export interface ResearchPayload {
   prosCons?: Record<string, string[]>;
   commonMistakes?: string[];
   sceneHints: SceneHint[];
-  infographicPath?: string; // URL to infographic (renamed semantically but kept for compat)
+  infographicUrl?: string;
 }
 
 export interface ResearchSource {
@@ -233,12 +234,6 @@ async function safeStep<T>(
 
 // ---------------------------------------------------------------------------
 // Sleep helper
-// ---------------------------------------------------------------------------
-
-function sleep(ms: number): Promise<void> {
-  return new Promise((resolve) => setTimeout(resolve, ms));
-}
-
 // ---------------------------------------------------------------------------
 // Main pipeline
 // ---------------------------------------------------------------------------
@@ -465,7 +460,7 @@ export async function conductResearch(
     talkingPoints,
     codeExamples,
     sceneHints,
-    infographicPath: infographicUrl ?? undefined,
+    infographicUrl: infographicUrl ?? undefined,
   };
 
   console.log(