fix: address PR #190 review — test exit codes, ILP/CircuitSAT ordering, edge trim

- Update 3 tests to expect non-zero exit when showing help (issue #189 item 9)
- Move ILP/CircuitSAT check before empty-flags help so they get the
  "via reduction" message instead of generic schema help
- Trim each side of edge pairs in parse_edge_pairs for robustness

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: GiggleLiu

problemreductions-cli/src/commands/create.rs

@@ -161,6 +161,17 @@ pub fn create(args: &CreateArgs, out: &OutputConfig) -> Result<()> {
         return create_random(args, canonical, &resolved_variant, out);
     }
 
+    // ILP and CircuitSAT have complex input structures not suited for CLI flags.
+    // Check before the empty-flags help so they get a clear message.
+    if canonical == "ILP" || canonical == "CircuitSAT" {
+        bail!(
+            "CLI creation is not yet supported for {canonical}.\n\n\
+             {canonical} instances are typically created via reduction:\n\
+               pred create MIS --graph 0-1,1-2 | pred reduce - --to {canonical}\n\n\
+             Or use the Rust API for direct construction."
+        );
+    }
+
     // Show schema-driven help when no data flags are provided
     if all_data_flags_empty(args) {
         let gt = if graph_type != "SimpleGraph" {
@@ -421,17 +432,6 @@ pub fn create(args: &CreateArgs, out: &OutputConfig) -> Result<()> {
             )
         }
 
-        // ILP and CircuitSAT have complex input structures not suited for CLI flags.
-        // They are typically created via reductions from other problems.
-        "ILP" | "CircuitSAT" => {
-            bail!(
-                "CLI creation is not yet supported for {canonical}.\n\n\
-                 {canonical} instances are typically created via reduction:\n\
-                   pred create MIS --graph 0-1,1-2 | pred reduce - --to {canonical}\n\n\
-                 Or use the Rust API for direct construction."
-            );
-        }
-
         _ => bail!("{}", crate::problem_name::unknown_problem_error(canonical)),
     };
 

problemreductions-cli/src/util.rs

@@ -250,8 +250,8 @@ pub fn parse_edge_pairs(s: &str) -> Result<Vec<(usize, usize)>> {
             if parts.len() != 2 {
                 bail!("Invalid edge '{}': expected format u-v", pair.trim());
             }
-            let u: usize = parts[0].parse()?;
-            let v: usize = parts[1].parse()?;
+            let u: usize = parts[0].trim().parse()?;
+            let v: usize = parts[1].trim().parse()?;
             Ok((u, v))
         })
         .collect()

problemreductions-cli/tests/cli_tests.rs

@@ -1105,12 +1105,11 @@ fn test_create_unknown_problem() {
 
 #[test]
 fn test_create_no_flags_shows_help() {
-    // pred create MIS with no data flags shows schema-driven help
+    // pred create MIS with no data flags shows schema-driven help and exits non-zero
     let output = pred().args(["create", "MIS"]).output().unwrap();
     assert!(
-        output.status.success(),
-        "stderr: {}",
-        String::from_utf8_lossy(&output.stderr)
+        !output.status.success(),
+        "should exit non-zero when showing help without data flags"
     );
     let stderr = String::from_utf8_lossy(&output.stderr);
     assert!(
@@ -2560,12 +2559,11 @@ fn test_create_factoring_with_bits() {
 
 #[test]
 fn test_create_factoring_no_flags_shows_help() {
-    // pred create Factoring with no data flags shows schema-driven help
+    // pred create Factoring with no data flags shows schema-driven help and exits non-zero
     let output = pred().args(["create", "Factoring"]).output().unwrap();
     assert!(
-        output.status.success(),
-        "stderr: {}",
-        String::from_utf8_lossy(&output.stderr)
+        !output.status.success(),
+        "should exit non-zero when showing help without data flags"
     );
     let stderr = String::from_utf8_lossy(&output.stderr);
     assert!(
@@ -2894,7 +2892,10 @@ fn test_create_kings_subgraph_help() {
         .args(["create", "MIS/KingsSubgraph"])
         .output()
         .unwrap();
-    assert!(output.status.success());
+    assert!(
+        !output.status.success(),
+        "should exit non-zero when showing help"
+    );
     let stderr = String::from_utf8(output.stderr).unwrap();
     assert!(
         stderr.contains("positions") || stderr.contains("MaximumIndependentSet"),