Skip to content

Commit 180fd7c

Browse files
zazabapclaude
andauthored
fix: check-issue skill delegates overhead comparison to check-rule-redundancy (#593)
Instead of manually parsing and comparing overhead tables, the usefulness check now invokes /check-rule-redundancy for full dominance analysis. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7721a91 commit 180fd7c

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

.claude/skills/check-issue/SKILL.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,10 @@ Applies when the title contains `[Rule]`.
7171

7272
4. Decision (principle: new rule must reduce the reduction overhead):
7373
- **No path exists****Pass** (novel reduction)
74-
- **Path exists** → compare overhead:
75-
- Parse the proposed overhead from the issue's "Size Overhead" table
76-
- Parse the overhead of the path.
77-
- If proposed overhead is **strictly lower** on at least one dimension (and not higher on any) → **Pass** ("improves existing reduction")
78-
- If overhead is **equal or higher** on all dimensions → **Fail**
79-
- If overhead comparison is ambiguous (different dimensions, incomparable expressions) → **Warn** with explanation
74+
- **Path exists** → run `/check-rule-redundancy <source> <target>` to perform a full overhead dominance analysis against all composite paths. Use its verdict:
75+
- **Not Redundant****Pass** ("improves existing reduction — not dominated by any composite path")
76+
- **Redundant** (dominated by a composite path) → **Fail** — include the dominating path from the redundancy report
77+
- **Inconclusive****Warn** with the details from the redundancy report
8078

8179
5. Check **Motivation** field: if empty, placeholder, or just "enables X" without explaining *why this path matters***Warn**
8280

0 commit comments

Comments
 (0)