Commit 52648df
* docs: add design for redundant rule detection utility (#193)
Detect primitive reduction rules dominated by composite paths using
asymptotic growth rate classification of overhead expressions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs: add implementation plan for redundant rule detection (#193)
4 tasks: GrowthRate enum + Expr::growth_rate(), analysis.rs module
with compare_overhead/find_dominated_rules, integration test with
allow-list, clippy/fmt.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: add polynomial comparison for overhead analysis (#193)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* test: add integration test for dominated rule detection (#193)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: clippy and format fixes (#193)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: remove redundant reduction rules (#193)
Remove trusted-redundant primitive reductions where composed paths
through existing canonical routes have equivalent or better overhead:
- MinimumVertexCover → QUBO (use MVC → MIS → QUBO)
- MinimumVertexCover → ILP (use MVC → MIS → ILP)
- MaximumSetPacking → ILP (use MSP → MIS → ILP)
- KSatisfiability K2/K3 → Satisfiability graph edges (use K2/K3 → KN → SAT)
K2 and K3 retain their typed ReduceTo<Satisfiability> impls for direct
use in code, but are no longer registered as primitive graph edges.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* save
* feat: refactor ILP to ILP<V> with VariableDomain trait
Remove bounds field. V=bool for binary (dims=2), V=i32 for
general integer (dims=2^31-1).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* refactor: update 9 reductions to target ILP<bool>
Remove VarBounds::binary() construction from all reductions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* refactor: update Factoring → ILP<i32> with carry bounds as constraints
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* refactor: ILP<bool> → QUBO with compile-time binary guarantee
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: add ILP<bool> → ILP<i32> cast reduction
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* refactor: update ILP solver for generic ILP<V>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* test: update all tests for ILP<V> refactor
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: remove ILP→QUBO from untrusted edges
ILP<bool>→QUBO overhead is now accurate (no slack ambiguity).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs: update paper and generated artifacts for ILP<V>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: rustfmt formatting fixes
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* clean up rules
* update
* update
* update
* update
* update
* update docs
* fix: address PR #194 review comments
- Delete plan files introduced in this PR (2026-03-09-*)
- Restore minimumvertexcover_to_qubo.json test data with new
test_vc_to_qubo_ground_truth using MVC → MIS → SetPacking → QUBO path
- Fix test_find_cheapest_path_is_to_qubo: use Minimize("num_vars")
instead of MinimizeSteps for deterministic path selection
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: update CLI tests for changed reduction graph paths
- test_path_overall_overhead_composition: 3SAT→MIS is now 3 steps
(K3→KN variant cast adds a step), relax assertion to >= 2
- test_path_single_step_no_overall_text: MIS→QUBO is no longer single
step (MIS→SP→QUBO), use MIS→MVC which is still 1 step
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 53c13f1 commit 52648df
90 files changed
Lines changed: 2806 additions & 2698 deletions
File tree
- .claude
- skills
- check-issue
- check-rule-redundancy
- docs
- paper
- src
- reductions
- examples
- problemreductions-cli/tests
- scripts
- src
- models/algebraic
- rules
- solvers/ilp
- topology
- unit_tests
- models/algebraic
- rules
- solvers/ilp
- topology
- unitdiskmapping_algorithms
- tests/suites
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
107 | | - | |
| 108 | + | |
108 | 109 | | |
109 | 110 | | |
110 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
0 commit comments