Skip to content

Commit 6356007

Browse files
GiggleLiuclaude
andcommitted
Rename Step 0c from 'Merge main' to 'Resolve conflicts with main'
Conflicts are the common case in a fast-moving codebase. Reorder bullets so 'Conflicted' comes first, 'Clean merge' second. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent eb63f8e commit 6356007

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.claude/skills/final-review/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,15 @@ cd "$WORKTREE_DIR"
8080
gh pr checkout "$PR"
8181
```
8282

83-
**0c. Merge main** (commit only, do not push yet — push happens in Step 8 after the review):
83+
**0c. Resolve conflicts with main** (commit only, do not push yet — push happens in Step 8 after the review):
8484

8585
```bash
8686
git fetch origin main
8787
git merge origin/main --no-edit
8888
```
8989

90-
- **Merge clean** — merge commit is ready locally. Run `make check && make paper` to verify the merge didn't break anything (API incompatibilities, formatting, test failures, paper compilation). If any step fails, fix the errors before proceeding. For `.bib` conflicts, also check for duplicate BibTeX keys (`grep '^@' docs/paper/references.bib | sed 's/@[a-z]*{//' | sed 's/,$//' | sort | uniq -d`) and remove duplicates.
91-
- **Merge conflicted**most conflicts in this codebase are "both sides added new entries in ordered lists" (in `mod.rs`, `lib.rs`, `create.rs`, `dispatch.rs`, `reductions.typ`). These are mechanical: keep both sides, maintain alphabetical order. Delegate to a subagent for resolution, then run `make check && make paper` to verify. Continue with the review; if conflicts are too complex, decide whether to hold in Step 5.
90+
- **Conflicted** (common case) — most conflicts in this codebase are "both sides added new entries in ordered lists" (in `mod.rs`, `lib.rs`, `create.rs`, `dispatch.rs`, `reductions.typ`). These are mechanical: keep both sides, maintain alphabetical order. Delegate to a subagent for resolution, then run `make check && make paper` to verify. For `.bib` conflicts, also check for duplicate BibTeX keys (`grep '^@' docs/paper/references.bib | sed 's/@[a-z]*{//' | sed 's/,$//' | sort | uniq -d`) and remove duplicates. Continue with the review; if conflicts are too complex, decide whether to hold in Step 5.
91+
- **Clean merge**merge commit is ready locally. Run `make check && make paper` to verify the merge didn't break anything (API incompatibilities, formatting, test failures, paper compilation). If any step fails, fix the errors before proceeding.
9292
- **Merge failed** — note the error and continue.
9393

9494
**0d. Sanity check**: verify the diff touches `src/models/` or `src/rules/` (for model/rule PRs). If the diff only contains unrelated files, STOP and flag the mismatch.

0 commit comments

Comments
 (0)