Skip to content

Commit 69d7f0c

Browse files
isPANNclaude
andcommitted
Renumber auto-pipeline integration gate as Step 3 (not 2.5)
Bumps review-pipeline to Step 4. Diagram, intro paragraph, cross-step references, and Common Mistakes table updated accordingly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 9a4f728 commit 69d7f0c

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

.claude/skills/auto-pipeline/SKILL.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ description: Use when you want to take a Backlog issue all the way to Final revi
77

88
Take **one** Backlog issue all the way from quality gate to **Final review** without human intervention. The merge step itself is still left to the human (see `/final-review`).
99

10-
This skill is an **orchestrator**: it never runs the heavy work itself. Each phase is delegated to a fresh-context subagent. Most phases invoke an existing skill (`check-issue`, `fix-issue`, `run-pipeline`, `review-pipeline`); Phase 2.5 is owned by the orchestrator and runs raw `cargo test --workspace` + `make paper` to catch breakage the per-item sub-skills cannot see. The only thing the main agent does directly is:
10+
This skill is an **orchestrator**: it never runs the heavy work itself. Each phase is delegated to a fresh-context subagent. Most phases invoke an existing skill (`check-issue`, `fix-issue`, `run-pipeline`, `review-pipeline`); Phase 3 is owned by the orchestrator and runs raw `cargo test --workspace` + `make paper` to catch breakage the per-item sub-skills cannot see. The only thing the main agent does directly is:
1111

1212
1. pick the issue,
1313
2. read structured reports from subagents,
@@ -68,8 +68,8 @@ digraph auto_pipeline {
6868
"Move to OnHold + comment" [shape=box, style=filled, fillcolor="#ffcccc"];
6969
"Move to Ready" [shape=box];
7070
"Phase 2: run-pipeline (subagent)" [shape=box, style=filled, fillcolor="#cce0ff"];
71-
"Phase 2.5: integration gate (subagent)" [shape=box, style=filled, fillcolor="#cce0ff"];
72-
"Phase 3: review-pipeline (subagent)" [shape=box, style=filled, fillcolor="#cce0ff"];
71+
"Phase 3: integration gate (subagent)" [shape=box, style=filled, fillcolor="#cce0ff"];
72+
"Phase 4: review-pipeline (subagent)" [shape=box, style=filled, fillcolor="#cce0ff"];
7373
"Final report" [shape=box, style=filled, fillcolor="#ccffcc"];
7474
7575
"Pick issue from Backlog" -> "Phase 1: check-issue (subagent)";
@@ -84,11 +84,11 @@ digraph auto_pipeline {
8484
"Substantive loop counter" -> "Phase 1: check-issue (subagent)" [label="< 2 retries"];
8585
"Substantive loop counter" -> "Move to OnHold + comment" [label=">= 2 retries"];
8686
"Move to Ready" -> "Phase 2: run-pipeline (subagent)";
87-
"Phase 2: run-pipeline (subagent)" -> "Phase 2.5: integration gate (subagent)" [label="success"];
87+
"Phase 2: run-pipeline (subagent)" -> "Phase 3: integration gate (subagent)" [label="success"];
8888
"Phase 2: run-pipeline (subagent)" -> "Final report" [label="fail (stop)"];
89-
"Phase 2.5: integration gate (subagent)" -> "Phase 3: review-pipeline (subagent)" [label="all pass"];
90-
"Phase 2.5: integration gate (subagent)" -> "Move to OnHold + comment" [label="any fail"];
91-
"Phase 3: review-pipeline (subagent)" -> "Final report";
89+
"Phase 3: integration gate (subagent)" -> "Phase 4: review-pipeline (subagent)" [label="all pass"];
90+
"Phase 3: integration gate (subagent)" -> "Move to OnHold + comment" [label="any fail"];
91+
"Phase 4: review-pipeline (subagent)" -> "Final report";
9292
}
9393
```
9494

@@ -331,7 +331,7 @@ Return ONLY this JSON shape:
331331

332332
When the subagent returns:
333333

334-
- **`outcome == "success"`** → continue to Step 2.5.
334+
- **`outcome == "success"`** → continue to Step 3.
335335
- **`outcome == "failure"`** → STOP. The `run-pipeline` skill already moves the card to OnHold and posts a diagnostic comment, so we do not duplicate. Print:
336336

337337
```
@@ -344,9 +344,9 @@ When the subagent returns:
344344

345345
Do NOT call codex to rescue here — implementation failures are CI/code-shape problems that need human eyes.
346346

347-
## Step 2.5: Integration Gate (orchestrator-owned)
347+
## Step 3: Integration Gate (orchestrator-owned)
348348

349-
The per-item sub-skills only test the new item in isolation, so cross-crate regressions (e.g. a relaxed model validator breaking pre-existing CLI tests) and paper-compile errors (orphan bib keys, math-mode typos like `intersect` vs Typst's `inter`) slip through Phase 2 and Phase 3. CI catches both, but in batch mode (many issues on one branch) breakage accumulates silently. Running this gate after every Phase 2 success closes the loop.
349+
The per-item sub-skills only test the new item in isolation, so cross-crate regressions (e.g. a relaxed model validator breaking pre-existing CLI tests) and paper-compile errors (orphan bib keys, math-mode typos like `intersect` vs Typst's `inter`) slip through Phase 2 and the per-item structural review. CI catches both, but in batch mode (many issues on one branch) breakage accumulates silently. Running this gate after every Phase 2 success closes the loop.
350350

351351
Dispatch a fresh subagent (`subagent_type=general-purpose`, not invoking any existing skill):
352352

@@ -359,10 +359,10 @@ Do not modify files. Return ONLY:
359359
"first_failure": "<first failing test or typst error, or empty>"}
360360
```
361361

362-
- Both `pass` → continue to Step 3.
363-
- Either `fail` → hand the `first_failure` to `codex:codex-rescue` for a fix-it pass (CI-class problems are usually small: deleting a stale test, fixing a typo'd bib key, swapping `intersect` for `inter`). After codex returns, re-run Step 2.5 once. If still failing, park on OnHold.
362+
- Both `pass` → continue to Step 4.
363+
- Either `fail` → hand the `first_failure` to `codex:codex-rescue` for a fix-it pass (CI-class problems are usually small: deleting a stale test, fixing a typo'd bib key, swapping `intersect` for `inter`). After codex returns, re-run Step 3 once. If still failing, park on OnHold.
364364

365-
## Step 3: Agentic Review (`review-pipeline` subagent)
365+
## Step 4: Agentic Review (`review-pipeline` subagent)
366366

367367
Dispatch the existing `review-pipeline` skill against the PR:
368368

@@ -404,4 +404,4 @@ Auto-pipeline complete:
404404
| Letting the codex subagent edit GitHub | The orchestrator owns all `gh issue edit` calls — codex only returns text |
405405
| Treating implementation failures as substantive issue problems | Step 2 failures go straight to a stop; they are not eligible for codex rescue |
406406
| Picking from a non-Backlog column when no issue number is given | Auto-pick must read from Backlog only — never from OnHold, Ready, or elsewhere |
407-
| Skipping Step 2.5 because Phase 2 reported `success` | Phase 2 success is scoped to the new item's own tests; workspace-wide regressions and paper-compile bugs are only visible from `make check` + `make paper`. |
407+
| Skipping Step 3 because Phase 2 reported `success` | Phase 2 success is scoped to the new item's own tests; workspace-wide regressions and paper-compile bugs are only visible from `make check` + `make paper`. |

0 commit comments

Comments
 (0)