Skip to content

Commit 8c86ffb

Browse files
GiggleLiuclaude
andcommitted
Fix run-review passing temp file path as format argument
review_pipeline_context takes (repo, pr, fmt) but the Makefile was passing a mktemp path as the third arg, causing --format to receive a file path instead of "json". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3ce1685 commit 8c86ffb

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -559,10 +559,8 @@ worktree-pr:
559559
run-review:
560560
@. scripts/make_helpers.sh; \
561561
repo=$${REPO:-$$(gh repo view --json nameWithOwner --jq .nameWithOwner)}; \
562-
tmp_state=$$(mktemp); \
563562
pr="$(N)"; \
564-
selection=$$(review_pipeline_context "$$repo" "$$pr" "$$tmp_state"); \
565-
rm -f "$$tmp_state"; \
563+
selection=$$(review_pipeline_context "$$repo" "$$pr"); \
566564
status_name=$$(printf '%s\n' "$$selection" | python3 -c "import sys,json; print(json.load(sys.stdin)['status'])"); \
567565
if [ "$$status_name" = "empty" ]; then \
568566
echo "No Review pool PRs are currently eligible."; \

0 commit comments

Comments
 (0)