You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add issue compliance checking to review-implementation skill
When review-implementation is called from the issue-to-pr flow, the
reviewers now fetch the linked issue from the PR and verify the
implementation matches the original requirements (problem definition,
reduction algorithm, overhead expressions, etc.).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: .claude/skills/review-implementation/structural-reviewer-prompt.md
+42-1Lines changed: 42 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,12 +6,17 @@ You are reviewing a new model or rule implementation for structural completeness
6
6
7
7
{REVIEW_PARAMS}
8
8
9
+
## Linked Issue
10
+
11
+
{ISSUE_CONTEXT}
12
+
9
13
## Instructions
10
14
11
15
1. Run the structural checklist below using Grep and Glob tools
12
16
2. Run `make test clippy` to verify build
13
17
3. Read the implementation files and perform semantic review
14
-
4. Output results in the structured format at the end
18
+
4. If a linked issue is provided, perform issue compliance review
19
+
5. Output results in the structured format at the end
15
20
16
21
## Model Checklist
17
22
@@ -84,6 +89,36 @@ Report pass/fail. If tests fail, identify which tests.
84
89
3.**Example quality** -- Is it tutorial-style? Does the JSON export include both source and target data?
85
90
4.**Paper quality** -- Is the reduction-rule statement precise? Is the proof sketch sound?
86
91
92
+
## Issue Compliance Review
93
+
94
+
Only run this section if a linked issue was provided (not "No linked issue found.").
95
+
96
+
Compare the implementation against the requirements in the original issue. The issue follows either the model checklist (from add-model) or the rule checklist (from add-rule).
97
+
98
+
### For Models (check against issue):
99
+
| # | Check | How to verify |
100
+
|---|-------|--------------|
101
+
| 1 | Problem name matches | Compare struct name against issue item 1 |
102
+
| 2 | Mathematical definition matches | Read `evaluate()` and verify it implements the definition from issue item 2 |
103
+
| 3 | Problem type matches | Verify optimization direction or satisfaction matches issue item 3 |
104
+
| 4 | Type parameters match | Verify struct generics match issue item 4 |
0 commit comments