Skip to content

Commit 9c1603c

Browse files
committed
update skills
1 parent 95edf16 commit 9c1603c

1 file changed

Lines changed: 2 additions & 13 deletions

File tree

scripts/test_pipeline_skill_context.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -226,13 +226,6 @@ def test_emit_result_prints_review_implementation_text_report(self) -> None:
226226
"whitelist": {"ok": True, "skipped": False},
227227
"completeness": {"ok": False, "skipped": False, "missing": ["paper_display_name"]},
228228
},
229-
"current_pr": {
230-
"repo": "CodingThrust/problem-reductions",
231-
"pr_number": 615,
232-
"title": "Fix #117: [Model] GraphPartitioning",
233-
"linked_issue_number": 117,
234-
"issue_context_text": "# Add GraphPartitioning\n\nNeed canonical example.",
235-
},
236229
}
237230

238231
stdout = io.StringIO()
@@ -244,11 +237,9 @@ def test_emit_result_prints_review_implementation_text_report(self) -> None:
244237
self.assertIn("- Base SHA: `abc123`", rendered)
245238
self.assertIn("- Review type: model", rendered)
246239
self.assertIn("- Name: GraphPartitioning", rendered)
247-
self.assertIn("- PR: #615", rendered)
248-
self.assertIn("- Linked issue: #117", rendered)
240+
self.assertNotIn("## Current PR", rendered)
249241
self.assertIn("## Deterministic Checks", rendered)
250242
self.assertIn("- Completeness: fail", rendered)
251-
self.assertIn("## Linked Issue Context", rendered)
252243

253244
def test_emit_result_prints_project_pipeline_text_report(self) -> None:
254245
result = {
@@ -405,7 +396,6 @@ def test_main_review_implementation_emits_ready_bundle_shape(self) -> None:
405396
"status": "ready",
406397
"git": {"base_sha": "abc123", "head_sha": "def456"},
407398
"review_context": {"subject": {"kind": "generic"}},
408-
"current_pr": None,
409399
}
410400

411401
with mock.patch.object(
@@ -832,7 +822,6 @@ def test_build_review_implementation_context_without_current_pr(self) -> None:
832822
"src/unit_tests/lib.rs",
833823
],
834824
added_files_getter=lambda repo_root, base_sha, head_sha: [],
835-
current_pr_fetcher=lambda: None,
836825
review_context_builder=lambda repo_root, **kwargs: {
837826
"scope": {"review_type": "generic", "models": [], "rules": [], "changed_files": kwargs["changed_files"]},
838827
"subject": {"kind": "generic"},
@@ -846,7 +835,7 @@ def test_build_review_implementation_context_without_current_pr(self) -> None:
846835
self.assertEqual(result["skill"], "review-implementation")
847836
self.assertEqual(result["status"], "ready")
848837
self.assertEqual(result["git"]["base_sha"], "abc123")
849-
self.assertEqual(result["current_pr"], None)
838+
self.assertNotIn("current_pr", result)
850839
self.assertEqual(result["review_context"]["subject"]["kind"], "generic")
851840

852841
def test_build_project_pipeline_context_reports_requested_blocked_issue(self) -> None:

0 commit comments

Comments
 (0)