You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .claude/skills/final-review/SKILL.md
+29Lines changed: 29 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -58,6 +58,32 @@ Collect all information needed for the review:
58
58
59
59
1f. **Check for conflicts with main**: Run `gh pr view <number> --json mergeable`. If there are merge conflicts, launch a subagent to merge `origin/main` into the PR branch (in a worktree) and push the merge commit.
60
60
61
+
1g. **PR / issue comment audit (REQUIRED)**: Final review must check the comment history before recommending merge.
62
+
- Set `REPO=$(gh repo view --json nameWithOwner --jq .nameWithOwner)`
63
+
- Fetch and read:
64
+
- PR conversation comments: `gh api repos/$REPO/issues/<number>/comments`
65
+
- PR inline review comments: `gh api repos/$REPO/pulls/<number>/comments`
66
+
- PR review bodies: `gh api repos/$REPO/pulls/<number>/reviews`
67
+
- linked issue comments, if an issue exists
68
+
- Build a list of every actionable comment and classify each as:
69
+
-`addressed`
70
+
-`superseded / no longer applicable`
71
+
-`still open`
72
+
- Pay special attention to the `## Review Pipeline Report` comment. If it contains a `Remaining issues for final review` section, those items must be reviewed explicitly here.
73
+
- Do **not** recommend merge until every actionable comment has been dispositioned.
74
+
75
+
1h. **Comment status summary**: Prepare a short summary for later steps:
76
+
77
+
> **Comment Audit**
78
+
>
79
+
> [N addressed, M superseded, K still open]
80
+
>
81
+
> Open items:
82
+
> -[comment / issue summary]
83
+
> - ...
84
+
85
+
If no actionable comments remain, report `No open actionable comments`.
86
+
61
87
### Step 2: Usefulness assessment
62
88
63
89
Think critically about whether this model/rule is genuinely useful. Consider:
@@ -212,6 +238,7 @@ Present a summary table:
212
238
213
239
| Aspect | Result |
214
240
|--------|--------|
241
+
| Comments |[All addressed / Open: X, Y]|
215
242
| Usefulness |[Useful/Marginal/Not useful]|
216
243
| Safety |[Safe/Concerns found]|
217
244
| Completeness |[Complete/Missing: X, Y]|
@@ -229,6 +256,8 @@ Then present all numbered issues from Step 5 as a multi-select `AskUserQuestion`
229
256
230
257
This lets the reviewer cherry-pick exactly which issues to fix. If the reviewer selects fixes, proceed to Step 7 Quick fix. If "Merge as-is", proceed to Step 7 Merge.
231
258
259
+
If any actionable PR / issue comment from Step 1g is still open, `Merge as-is` must **not** be your recommendation. Recommend either **Quick fix** or **OnHold** instead.
Copy file name to clipboardExpand all lines: .claude/skills/review-pipeline/SKILL.md
+31-3Lines changed: 31 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -245,9 +245,21 @@ Run agentic feature tests on the modified feature:
245
245
246
246
2. **Invoke `/agentic-tests:test-feature`** with the identified feature. This simulates a downstream user exercising the feature from docs and examples. You MUST use the Skill tool to invoke `agentic-tests:test-feature`.
247
247
248
-
3. **If test-feature reports issues:** fix them, commit, and push.
249
-
250
-
4. **If test-feature passes:** continue to next step.
248
+
3. **If test-feature reports issues:** treat every reported issue as real until you have checked it in the **current PR worktree/branch**.
249
+
- Reproduce each issue from the current PR branch/worktree before acting. If it does not reproduce there, classify it as `not reproducible in current worktree`.
250
+
- Auto-fix every objective issue you reasonably can: code bugs, tests, docs, help text, examples, discoverability gaps, and validation/error-message problems. Do **not** leave "minor docs issues" unfixed by default.
251
+
- If you changed user-facing behavior, docs, or CLI help, re-run `/agentic-tests:test-feature`.
252
+
- Classify every reported issue as exactly one of:
253
+
- `fixed`
254
+
- `not reproducible in current worktree`
255
+
- `needs human decision`
256
+
257
+
4. **Only `needs human decision` issues may remain unresolved.** If any remain:
258
+
- continue to the next step only after you have written them down for the final PR report
259
+
- include why they were not auto-fixed
260
+
- include your recommended maintainer decision
261
+
262
+
5. **If test-feature passes with no remaining issues:** continue to next step.
| Only checking Copilot comments | Step 2a checks human PR reviews and linked issue comments too — bot-only review is insufficient |
394
+
| Saying "passed"while deferring issues | If anything remains for maintainer judgment, list it explicitly under `Remaining issues for final review` and mark the agentic result accordingly |
0 commit comments