Skip to content

feat: add prerequisite gate and orphan check to check-issue skill#265

Closed
isPANN wants to merge 1 commit into
mainfrom
check-issue-prerequisites
Closed

feat: add prerequisite gate and orphan check to check-issue skill#265
isPANN wants to merge 1 commit into
mainfrom
check-issue-prerequisites

Conversation

@isPANN
Copy link
Copy Markdown
Collaborator

@isPANN isPANN commented Mar 11, 2026

Summary

  • Rule Check 0 (Prerequisites): Before evaluating a [Rule] issue, verify both source and target problems are implemented in the codebase. If either is missing, fail with Blocked label and skip all remaining checks.
  • Rule Check 3e (Code cross-validation): Cross-validate issue content against actual code implementations — fields, methods, objective direction, and size metric names.
  • Model Check 1.5 (Orphan prevention): Verify at least one [Rule] issue references the model as source or target. If none found, fail with Orphan label.

These create a mutual dependency that ensures the reduction graph stays connected:

  • [Rule] issues require both problems to be implemented → prevents rules referencing nonexistent problems
  • [Model] issues require at least one [Rule] issue → prevents orphan nodes

Also updates flow diagram, report templates, and label application section.

Closes #264

Test plan

🤖 Generated with Claude Code

- Add Rule Check 0: require source/target implementations before evaluating
  [Rule] issues. Fails with `Blocked` label and skips remaining checks.
- Add Rule Check 3e: cross-validate issue content against actual code
  implementations (fields, methods, objective direction).
- Add Model Check 1.5: verify at least one [Rule] issue references the
  model to prevent orphan nodes. Fails with `Orphan` label.
- Update flow diagram, report templates, and label application section.

Closes #264

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.37%. Comparing base (52648df) to head (1faf39e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         200      200           
  Lines       27871    27871           
=======================================
  Hits        26861    26861           
  Misses       1010     1010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@isPANN isPANN closed this Mar 12, 2026
@GiggleLiu GiggleLiu deleted the check-issue-prerequisites branch April 12, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check-issue: require source/target implementations for [Rule] checks and cross-validate against code

1 participant