-
Notifications
You must be signed in to change notification settings - Fork 7
Fix complexity inconsistencies, enforce overhead, add missing variants #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
8656c0f
8adf946
4be9c01
e02efb3
7875f2b
2cfb1b7
d420532
8dce81c
e028261
ac760a8
e4d81a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -253,7 +253,12 @@ fn generate_reduction_entry( | |||||
| let overhead = match &attrs.overhead { | ||||||
| Some(OverheadSpec::Legacy(tokens)) => tokens.clone(), | ||||||
| Some(OverheadSpec::Parsed(fields)) => generate_parsed_overhead(fields)?, | ||||||
| None => quote! { crate::rules::registry::ReductionOverhead::default() }, | ||||||
| None => { | ||||||
| return Err(syn::Error::new( | ||||||
| proc_macro2::Span::call_site(), | ||||||
| "#[reduction] requires overhead = { ... }. Specify overhead expressions for all target problem size fields.", | ||||||
|
||||||
| "#[reduction] requires overhead = { ... }. Specify overhead expressions for all target problem size fields.", | |
| "Missing overhead specification. Use #[reduction(overhead = { ... })] and specify overhead expressions for all target problem size fields.", |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -163,7 +163,7 @@ impl OptimizationProblem for Factoring { | |||||
| } | ||||||
|
|
||||||
| crate::declare_variants! { | ||||||
| Factoring => "exp(sqrt(num_bits))", | ||||||
| Factoring => "exp(num_bits^(1/3) * log(num_bits)^(2/3))", | ||||||
|
||||||
| Factoring => "exp(num_bits^(1/3) * log(num_bits)^(2/3))", | |
| Factoring => "exp((m + n)^(1/3) * log(m + n)^(2/3))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new BibTeX entry uses LaTeX accent escapes in the author field (e.g.,
Ji\v{r}\'{\i}), while the rest ofreferences.bibappears to use plain text. Typst/Bib parsers often don't fully expand LaTeX macros, which can lead to incorrect rendering in the compiled paper. Consider replacing the escapes with the actual Unicode characters (e.g., "Jiří Fiala") to ensure consistent bibliography output.