feat: add prerequisite gate and orphan check to check-issue skill#265
Closed
isPANN wants to merge 1 commit into
Closed
feat: add prerequisite gate and orphan check to check-issue skill#265isPANN wants to merge 1 commit into
isPANN wants to merge 1 commit into
Conversation
- Add Rule Check 0: require source/target implementations before evaluating [Rule] issues. Fails with `Blocked` label and skips remaining checks. - Add Rule Check 3e: cross-validate issue content against actual code implementations (fields, methods, objective direction). - Add Model Check 1.5: verify at least one [Rule] issue references the model to prevent orphan nodes. Fails with `Orphan` label. - Update flow diagram, report templates, and label application section. Closes #264 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 200 200
Lines 27871 27871
=======================================
Hits 26861 26861
Misses 1010 1010 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Rule]issue, verify both source and target problems are implemented in the codebase. If either is missing, fail withBlockedlabel and skip all remaining checks.[Rule]issue references the model as source or target. If none found, fail withOrphanlabel.These create a mutual dependency that ensures the reduction graph stays connected:
[Rule]issues require both problems to be implemented → prevents rules referencing nonexistent problems[Model]issues require at least one[Rule]issue → prevents orphan nodesAlso updates flow diagram, report templates, and label application section.
Closes #264
Test plan
🤖 Generated with Claude Code