Skip to content

Fix #95: Add BinPacking model #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GiggleLiu merged 13 commits into from
Feb 28, 2026
Merged

Fix #95: Add BinPacking model #96

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
abb24c6
Add plan for #95: BinPacking model
GiggleLiu Feb 25, 2026
b6bc116
feat: add BinPacking model (optimization, minimize bins)
GiggleLiu Feb 25, 2026
7a3a180
test: add BinPacking unit tests
GiggleLiu Feb 25, 2026
a4040e1
feat: register BinPacking in CLI dispatch
GiggleLiu Feb 25, 2026
544c967
docs: add BinPacking problem definition to paper
GiggleLiu Feb 25, 2026
252eee8
update
GiggleLiu Feb 25, 2026
45ee95b
Merge branch 'main' into issue-95-bin-packing
GiggleLiu Feb 28, 2026
ada30fd
fix run-plan
GiggleLiu Feb 28, 2026
2cdd9f5
fix: clippy warnings, add BinPacking edge-case tests and variant decl…
GiggleLiu Feb 28, 2026
e926fc5
fix model add
GiggleLiu Feb 28, 2026
97df27d
fix: update BinPacking model for main refactors, enrich paper entry
GiggleLiu Feb 28, 2026
ac565eb
fix: address PR #96 review feedback
GiggleLiu Feb 28, 2026
eb6f8f5
chore: remove completed BinPacking plan file
GiggleLiu Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,4 @@ claude-output.log
.worktrees/
.worktree/
*.json
.claude/worktrees/
5 changes: 3 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,13 @@ PLAN_FILE ?= $(shell ls -t docs/plans/*.md 2>/dev/null | head -1)
run-plan:
@NL=$$'\n'; \
BRANCH=$$(git branch --show-current); \
PLAN_FILE="$(PLAN_FILE)"; \
if [ "$(AGENT_TYPE)" = "claude" ]; then \
PROCESS="1. Read the plan file$${NL}2. Use /subagent-driven-development to execute tasks$${NL}3. Push: git push origin $$BRANCH$${NL}4. Create a pull request"; \
PROCESS="1. Read the plan file$${NL}2. Choose the right skill to execute: use /add-model for new problem models, /add-rule for new reduction rules, or /subagent-driven-development for other tasks$${NL}3. Push: git push origin $$BRANCH$${NL}4. Create a pull request"; \
else \
PROCESS="1. Read the plan file$${NL}2. Execute the tasks step by step. For each task, implement and test before moving on.$${NL}3. Push: git push origin $$BRANCH$${NL}4. Create a pull request"; \
fi; \
PROMPT="Execute the plan in '$${PLAN_FILE}'."; \
PROMPT="Execute the plan in '$$PLAN_FILE'."; \
Comment on lines 189 to +198
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is described as adding the BinPacking model, but it also changes the run-plan Makefile workflow/prompt logic. If these Makefile changes are intentional, please mention them in the PR description; otherwise consider splitting them into a separate PR to keep scope focused and make review/audit easier.

Copilot uses AI. Check for mistakes.
if [ -n "$(INSTRUCTIONS)" ]; then \
PROMPT="$${PROMPT}$${NL}$${NL}## Additional Instructions$${NL}$(INSTRUCTIONS)"; \
fi; \
Expand Down
5 changes: 5 additions & 0 deletions docs/paper/reductions.typ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"BMF": [Boolean Matrix Factorization],
"PaintShop": [Paint Shop],
"BicliqueCover": [Biclique Cover],
"BinPacking": [Bin Packing],
)

// Definition label: "def:<ProblemName>" — each definition block must have a matching label
Expand Down Expand Up @@ -801,6 +802,10 @@ Biclique Cover is equivalent to factoring the biadjacency matrix $M$ of the bipa
) <fig:biclique-cover>
]

#problem-def("BinPacking")[
Given $n$ items with sizes $s_1, dots, s_n in RR^+$ and bin capacity $C > 0$, find an assignment $x: {1, dots, n} -> {1, dots, n}$ minimizing $|{x(i) : i = 1, dots, n}|$ (number of distinct bins used) subject to $forall j: sum_(i: x(i) = j) s_i lt.eq C$.
]

// Completeness check: warn about problem types in JSON but missing from paper
#{
let json-models = {
Expand Down
Loading