youtube-dl is now neccesary for playing youtube videos

Author: Maximilian Brune

README.md

@@ -8,7 +8,7 @@ mumble library written in go. Intended for writing client side music bots.
 - If you don't want to study the entire Code in order to find out what you can do with this library and how, I made a README.md file in most folder explaining what each .go source file does. Furthermore the README file in the gomble directory shows a little illustration (sequence diagram) written in plantuml on how it works.
 
 ## Features
-- you can play youtube videos ~~(without any additional dependency)~~ (it's now recommended to have youtube-dl installed)
+- you can play youtube videos ~~(without any additional dependency)~~ (for playing youtube-videos it is now necessary to have youtube-dl installed)
 - it automatically uses UDP for sending audio data
 - Buffering, so no disruptions in hearing "should" occur
 - Stereo sound (since mumble 1.4 or newer)

gomble/track.go

@@ -43,7 +43,8 @@ func LoadTrack(url string) (*Track, error) {
             src, err = youtube.NewYoutubedlVideo(surl)
         } else {
             // otherwise use native youtube stream implementation (probably doesn't work, but worth a try)
-            src, err = youtube.NewYoutubeVideo(surl)
+           // src, err = youtube.NewYoutubeVideo(surl)
+           logger.Fatalf("No Youtube-dl installed. exiting\n")
         }
         if err != nil {
             return nil, err

main.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"regexp"
 	"strings"
 
 	"github.com/CodingVoid/gomble/gomble"
@@ -34,20 +33,8 @@ func OnChannelMessageReceived(e gomble.ChannelMessageReceivedEvent) {
 	// set current channel
 	currentChannel = gomble.GetChannel(e.Channel)
 	if strings.HasPrefix(e.Message, "#play ") {
-		var url string
-		fields := strings.Fields(e.Message)
-		if fields[1] == "<a" {
-			// there is an html encoded link
-			// <a href=link>link</a>
-			re := regexp.MustCompile(`https://www.youtube.com/watch\?v=[a-zA-Z0-9\-\_]+`) // need to use ` character otherwise \character are recognized as escape characters
-			matches := re.FindStringSubmatch(e.Message)
-			url = matches[0]
-		} else {
-			// probably not html encoded (maybe allowHTML is off?)
-			url = strings.Fields(e.Message)[1]
-		}
-		logger.Debugf(url + "\n")
-		yt, err := gomble.LoadTrack(url)
+		logger.Debugf(e.Message + "\n")
+		yt, err := gomble.LoadTrack(e.Message)
 		if err != nil {
 			logger.Errorf("%v", err)
             return