Skip to content

Commit 9f7da93

Browse files
committed
fix(telemetry): remove sensitive data from telemetry
Remove project names and file paths from telemetry tags and logs to avoid sending potentially sensitive information.
1 parent a5ea6ed commit 9f7da93

1 file changed

Lines changed: 5 additions & 10 deletions

File tree

src/CodingWithCalvin.ProjectRenamifier/Commands/RenamifyProjectCommand.cs

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ private void RenameProject(Project project, DTE2 dte)
7070
using var activity = VsixTelemetry.StartCommandActivity("ProjectRenamifier.RenameProject");
7171

7272
var currentName = Path.GetFileNameWithoutExtension(project.FullName);
73-
activity?.SetTag("project.current_name", currentName);
74-
75-
var dialog = new RenameProjectDialog(currentName);
73+
var dialog = new RenameProjectDialog(currentName);
7674

7775
// Set the owner to the VS main window for proper modal behavior
7876
var helper = new WindowInteropHelper(dialog)
@@ -82,16 +80,15 @@ private void RenameProject(Project project, DTE2 dte)
8280

8381
if (dialog.ShowDialog() != true)
8482
{
85-
VsixTelemetry.LogInformation("Rename cancelled by user for project {ProjectName}", currentName);
83+
VsixTelemetry.LogInformation("Rename cancelled by user");
8684
return;
8785
}
8886

8987
var newName = dialog.NewProjectName;
9088
var projectFilePath = project.FullName;
9189
var originalProjectFilePath = projectFilePath;
9290

93-
activity?.SetTag("project.new_name", newName);
94-
VsixTelemetry.LogInformation("Renaming project from {OldName} to {NewName}", currentName, newName);
91+
VsixTelemetry.LogInformation("Renaming project");
9592

9693
// Show progress dialog
9794
var progressDialog = new RenameProgressDialog(currentName);
@@ -186,7 +183,7 @@ private void RenameProject(Project project, DTE2 dte)
186183

187184
activity?.SetTag("rename.success", true);
188185
activity?.SetTag("rename.steps_completed", stepIndex);
189-
VsixTelemetry.LogInformation("Successfully renamed project from {OldName} to {NewName}", currentName, newName);
186+
VsixTelemetry.LogInformation("Successfully renamed project");
190187
}
191188
catch (Exception ex)
192189
{
@@ -201,8 +198,6 @@ private void RenameProject(Project project, DTE2 dte)
201198
VsixTelemetry.TrackException(ex, new Dictionary<string, object>
202199
{
203200
{ "operation.name", "RenameProject" },
204-
{ "project.old_name", currentName },
205-
{ "project.new_name", newName },
206201
{ "step.index", stepIndex }
207202
});
208203

@@ -215,7 +210,7 @@ private void RenameProject(Project project, DTE2 dte)
215210
var currentProjectPath = File.Exists(projectFilePath) ? projectFilePath : originalProjectFilePath;
216211
if (File.Exists(currentProjectPath))
217212
{ SolutionFolderService.AddProjectToSolution(dte.Solution, currentProjectPath, parentSolutionFolder);
218-
VsixTelemetry.LogInformation("Rollback: Re-added project at {ProjectPath}", currentProjectPath);
213+
VsixTelemetry.LogInformation("Rollback: Re-added project");
219214
}
220215
}
221216
catch (Exception rollbackEx)

0 commit comments

Comments
 (0)