feat(services): implement CPS-compatible project enumeration#7
Merged
Conversation
Add interfaces and MSBuild query service for improved project handling: Interfaces: - ISolutionService for solution project enumeration - IManifestService for manifest loading/saving - IMsBuildQueryService for MSBuild property and target queries Implementation: - MsBuildQueryService with XML-based property and target detection - Special handling for TemplateProjectOutputGroup target detection - SolutionService now implements ISolutionService interface - ManifestService now implements IManifestService interface Model updates: - Add HasTemplateOutputGroup property to ProjectInfo Closes #3
…vider SVsServiceProvider is not retrievable via GetGlobalService, causing the Add buttons in AssetsView and DependenciesView to silently fail. Changed to use ServiceProvider.GlobalProvider which is always available.
StaticResource is resolved at XAML parse time, so adding the converter in code-behind after InitializeComponent() fails. Moved the converter definition to XAML resources where it's available during parsing.
- Filter out the project containing the manifest being edited from the project picker (can't add a project as an asset to itself) - Add ManifestFilePath property to ManifestViewModel - Pass manifest path through AddAssetDialog to ProjectPickerDialog - Add HasMaximizeButton/HasMinimizeButton="False" to all dialogs for consistent VS-style dialog appearance
Add DialogHelper class that uses IVsUIShell.GetDialogOwnerHwnd() to properly parent dialogs to the Visual Studio main window. This ensures dialogs stay with VS when alt-tabbing and appear in front of VS. - Create DialogHelper with SetOwner and ShowDialogWithOwner methods - Update all views and dialogs to use DialogHelper.ShowDialogWithOwner - Add ThreadHelper.ThrowIfNotOnUIThread() calls to satisfy analyzer
- Add logo.png to resources folder - Configure manifest with Icon and PreviewImage - Move LICENSE to resources\LICENSE in VSIX - Update csproj to include logo in VSIX package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #3