-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathpath_test.go
More file actions
422 lines (356 loc) · 11.4 KB
/
path_test.go
File metadata and controls
422 lines (356 loc) · 11.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
package path
import (
"os"
"path/filepath"
"runtime"
"strings"
"testing"
"github.com/CodingWithCalvin/dtvem.cli/src/internal/constants"
)
func TestIsInPath(t *testing.T) {
// Get current PATH
originalPath := os.Getenv("PATH")
tests := []struct {
name string
dir string
setupPath string
expected bool
}{
{
name: "Directory exists in PATH",
dir: "/usr/bin",
setupPath: "/usr/bin:/usr/local/bin",
expected: true,
},
{
name: "Directory not in PATH",
dir: "/nonexistent",
setupPath: "/usr/bin:/usr/local/bin",
expected: false,
},
{
name: "Empty PATH",
dir: "/usr/bin",
setupPath: "",
expected: false,
},
}
// Adjust separator for Windows
separator := ":"
if runtime.GOOS == constants.OSWindows {
separator = ";"
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Setup test PATH
testPath := strings.ReplaceAll(tt.setupPath, ":", separator)
_ = os.Setenv("PATH", testPath)
// Clean the directory path for comparison
cleanDir := filepath.Clean(tt.dir)
result := IsInPath(cleanDir)
if result != tt.expected {
t.Errorf("IsInPath(%q) with PATH=%q = %v, want %v",
cleanDir, testPath, result, tt.expected)
}
})
}
// Restore original PATH
_ = os.Setenv("PATH", originalPath)
}
func TestIsInPath_WithSpaces(t *testing.T) {
originalPath := os.Getenv("PATH")
defer func() { _ = os.Setenv("PATH", originalPath) }()
separator := ":"
if runtime.GOOS == constants.OSWindows {
separator = ";"
}
testDir := "/path with spaces"
testPath := strings.Join([]string{"/usr/bin", testDir, "/usr/local/bin"}, separator)
_ = os.Setenv("PATH", testPath)
if !IsInPath(testDir) {
t.Errorf("IsInPath(%q) = false, want true (should handle spaces in paths)", testDir)
}
}
func TestShimsDir(t *testing.T) {
result := ShimsDir()
// Should return a non-empty path
if result == "" {
t.Error("ShimsDir() returned empty string")
}
// Should contain 'dtvem' (either .dtvem or .local/share/dtvem on Linux)
if !strings.Contains(result, "dtvem") {
t.Errorf("ShimsDir() = %q, should contain 'dtvem'", result)
}
// Should end with 'shims'
if !strings.HasSuffix(result, "shims") {
t.Errorf("ShimsDir() = %q, should end with 'shims'", result)
}
// Should be an absolute path
if !filepath.IsAbs(result) {
t.Errorf("ShimsDir() = %q, should be an absolute path", result)
}
}
func TestShimsDir_WithDTVEMROOT(t *testing.T) {
// Save original environment
originalRoot := os.Getenv("DTVEM_ROOT")
defer func() {
if originalRoot != "" {
_ = os.Setenv("DTVEM_ROOT", originalRoot)
} else {
_ = os.Unsetenv("DTVEM_ROOT")
}
}()
// Set custom DTVEM_ROOT
customRoot := filepath.Join(os.TempDir(), "custom-dtvem-root")
_ = os.Setenv("DTVEM_ROOT", customRoot)
result := ShimsDir()
expected := filepath.Join(customRoot, "shims")
if result != expected {
t.Errorf("ShimsDir() with DTVEM_ROOT=%q = %q, want %q", customRoot, result, expected)
}
}
func TestShimsDir_NonLinux_WithXDG(t *testing.T) {
// On non-Linux platforms, verify that XDG_DATA_HOME is respected when set
if runtime.GOOS == constants.OSLinux {
t.Skip("This test only runs on non-Linux platforms")
}
// Save original environment
originalRoot := os.Getenv("DTVEM_ROOT")
originalXDG := os.Getenv("XDG_DATA_HOME")
defer func() {
if originalRoot != "" {
_ = os.Setenv("DTVEM_ROOT", originalRoot)
} else {
_ = os.Unsetenv("DTVEM_ROOT")
}
if originalXDG != "" {
_ = os.Setenv("XDG_DATA_HOME", originalXDG)
} else {
_ = os.Unsetenv("XDG_DATA_HOME")
}
}()
// Clear DTVEM_ROOT and set XDG_DATA_HOME
_ = os.Unsetenv("DTVEM_ROOT")
customXDG := filepath.Join(os.TempDir(), "custom-xdg-data")
_ = os.Setenv("XDG_DATA_HOME", customXDG)
result := ShimsDir()
expected := filepath.Join(customXDG, "dtvem", "shims")
if result != expected {
t.Errorf("ShimsDir() on %s should use XDG_DATA_HOME when set, got %q, want %q",
runtime.GOOS, result, expected)
}
}
func TestShimsDir_NonLinux_WithoutXDG(t *testing.T) {
// On non-Linux platforms, verify that ~/.dtvem/shims is used when XDG_DATA_HOME is not set
if runtime.GOOS == constants.OSLinux {
t.Skip("This test only runs on non-Linux platforms")
}
// Save original environment
originalRoot := os.Getenv("DTVEM_ROOT")
originalXDG := os.Getenv("XDG_DATA_HOME")
defer func() {
if originalRoot != "" {
_ = os.Setenv("DTVEM_ROOT", originalRoot)
} else {
_ = os.Unsetenv("DTVEM_ROOT")
}
if originalXDG != "" {
_ = os.Setenv("XDG_DATA_HOME", originalXDG)
} else {
_ = os.Unsetenv("XDG_DATA_HOME")
}
}()
// Clear both DTVEM_ROOT and XDG_DATA_HOME
_ = os.Unsetenv("DTVEM_ROOT")
_ = os.Unsetenv("XDG_DATA_HOME")
result := ShimsDir()
home, _ := os.UserHomeDir()
expected := filepath.Join(home, ".dtvem", "shims")
if result != expected {
t.Errorf("ShimsDir() on %s without XDG_DATA_HOME should use ~/.dtvem/shims, got %q, want %q",
runtime.GOOS, result, expected)
}
}
func TestShimsDir_DTVEMRootOverridesXDG(t *testing.T) {
// Verify that DTVEM_ROOT takes precedence over XDG_DATA_HOME
originalRoot := os.Getenv("DTVEM_ROOT")
originalXDG := os.Getenv("XDG_DATA_HOME")
defer func() {
if originalRoot != "" {
_ = os.Setenv("DTVEM_ROOT", originalRoot)
} else {
_ = os.Unsetenv("DTVEM_ROOT")
}
if originalXDG != "" {
_ = os.Setenv("XDG_DATA_HOME", originalXDG)
} else {
_ = os.Unsetenv("XDG_DATA_HOME")
}
}()
// Set both DTVEM_ROOT and XDG_DATA_HOME
customRoot := filepath.Join(os.TempDir(), "custom-dtvem-root")
_ = os.Setenv("DTVEM_ROOT", customRoot)
_ = os.Setenv("XDG_DATA_HOME", filepath.Join(os.TempDir(), "should-be-ignored"))
result := ShimsDir()
expected := filepath.Join(customRoot, "shims")
if result != expected {
t.Errorf("ShimsDir() with DTVEM_ROOT set should return DTVEM_ROOT/shims, got %q, want %q",
result, expected)
}
}
func TestLookPathExcludingShims(t *testing.T) {
originalPath := os.Getenv("PATH")
defer func() { _ = os.Setenv("PATH", originalPath) }()
// Create temp directories for testing
tempDir := t.TempDir()
systemDir := filepath.Join(tempDir, "system")
shimsDir := filepath.Join(tempDir, "shims")
if err := os.MkdirAll(systemDir, 0755); err != nil {
t.Fatalf("Failed to create system dir: %v", err)
}
if err := os.MkdirAll(shimsDir, 0755); err != nil {
t.Fatalf("Failed to create shims dir: %v", err)
}
// Create test executables
execName := "testexec"
var systemExec, shimsExec string
if runtime.GOOS == constants.OSWindows {
systemExec = filepath.Join(systemDir, execName+".exe")
shimsExec = filepath.Join(shimsDir, execName+".exe")
} else {
systemExec = filepath.Join(systemDir, execName)
shimsExec = filepath.Join(shimsDir, execName)
}
// Create dummy executables
if err := os.WriteFile(systemExec, []byte("system"), 0755); err != nil {
t.Fatalf("Failed to create system exec: %v", err)
}
if err := os.WriteFile(shimsExec, []byte("shim"), 0755); err != nil {
t.Fatalf("Failed to create shims exec: %v", err)
}
t.Run("Finds executable in system dir", func(t *testing.T) {
separator := ":"
if runtime.GOOS == constants.OSWindows {
separator = ";"
}
testPath := strings.Join([]string{systemDir}, separator)
_ = os.Setenv("PATH", testPath)
result := LookPathExcludingShims(execName)
if result != systemExec {
t.Errorf("LookPathExcludingShims(%q) = %q, want %q", execName, result, systemExec)
}
})
t.Run("Returns empty when not found", func(t *testing.T) {
_ = os.Setenv("PATH", systemDir)
result := LookPathExcludingShims("nonexistent")
if result != "" {
t.Errorf("LookPathExcludingShims(%q) = %q, want empty string", "nonexistent", result)
}
})
t.Run("Returns empty with empty PATH", func(t *testing.T) {
_ = os.Setenv("PATH", "")
result := LookPathExcludingShims(execName)
if result != "" {
t.Errorf("LookPathExcludingShims(%q) with empty PATH = %q, want empty string", execName, result)
}
})
}
func TestLookPathExcludingShims_SkipsShimsDir(t *testing.T) {
originalPath := os.Getenv("PATH")
defer func() { _ = os.Setenv("PATH", originalPath) }()
// Get the actual shims directory that will be excluded
shimsDir := ShimsDir()
// Create temp directory for "system" install
tempDir := t.TempDir()
systemDir := filepath.Join(tempDir, "system")
if err := os.MkdirAll(systemDir, 0755); err != nil {
t.Fatalf("Failed to create system dir: %v", err)
}
// Create shims directory if it doesn't exist (for testing)
if err := os.MkdirAll(shimsDir, 0755); err != nil {
t.Fatalf("Failed to create shims dir: %v", err)
}
execName := "lookuptest"
var systemExec, shimsExec string
if runtime.GOOS == constants.OSWindows {
systemExec = filepath.Join(systemDir, execName+".exe")
shimsExec = filepath.Join(shimsDir, execName+".exe")
} else {
systemExec = filepath.Join(systemDir, execName)
shimsExec = filepath.Join(shimsDir, execName)
}
// Create dummy executables
if err := os.WriteFile(systemExec, []byte("system"), 0755); err != nil {
t.Fatalf("Failed to create system exec: %v", err)
}
if err := os.WriteFile(shimsExec, []byte("shim"), 0755); err != nil {
t.Fatalf("Failed to create shims exec: %v", err)
}
// Clean up shims exec after test
defer func() { _ = os.Remove(shimsExec) }()
separator := ":"
if runtime.GOOS == constants.OSWindows {
separator = ";"
}
t.Run("Skips shims dir and finds system install", func(t *testing.T) {
// Put shims dir FIRST in PATH, then system dir
testPath := strings.Join([]string{shimsDir, systemDir}, separator)
_ = os.Setenv("PATH", testPath)
result := LookPathExcludingShims(execName)
// Should find the system exec, NOT the shims exec
if result != systemExec {
t.Errorf("LookPathExcludingShims(%q) = %q, want %q (should skip shims dir)", execName, result, systemExec)
}
})
t.Run("Returns empty when only in shims dir", func(t *testing.T) {
// Put ONLY shims dir in PATH
_ = os.Setenv("PATH", shimsDir)
result := LookPathExcludingShims(execName)
// Should return empty since shims dir is excluded
if result != "" {
t.Errorf("LookPathExcludingShims(%q) = %q, want empty (shims dir should be excluded)", execName, result)
}
})
}
func TestFindExecutableInDir(t *testing.T) {
tempDir := t.TempDir()
execName := "findtest"
var execPath string
if runtime.GOOS == constants.OSWindows {
execPath = filepath.Join(tempDir, execName+".exe")
} else {
execPath = filepath.Join(tempDir, execName)
}
// Create dummy executable
if err := os.WriteFile(execPath, []byte("test"), 0755); err != nil {
t.Fatalf("Failed to create exec: %v", err)
}
t.Run("Finds executable", func(t *testing.T) {
result := findExecutableInDir(tempDir, execName)
if result != execPath {
t.Errorf("findExecutableInDir(%q, %q) = %q, want %q", tempDir, execName, result, execPath)
}
})
t.Run("Returns empty for nonexistent", func(t *testing.T) {
result := findExecutableInDir(tempDir, "nonexistent")
if result != "" {
t.Errorf("findExecutableInDir(%q, %q) = %q, want empty", tempDir, "nonexistent", result)
}
})
t.Run("Returns empty for directory with same name", func(t *testing.T) {
dirName := "isdir"
var dirPath string
if runtime.GOOS == constants.OSWindows {
dirPath = filepath.Join(tempDir, dirName+".exe")
} else {
dirPath = filepath.Join(tempDir, dirName)
}
if err := os.MkdirAll(dirPath, 0755); err != nil {
t.Fatalf("Failed to create dir: %v", err)
}
result := findExecutableInDir(tempDir, dirName)
if result != "" {
t.Errorf("findExecutableInDir should not return directories, got %q", result)
}
})
}