Skip to content

Commit 186a15a

Browse files
authored
fix(ci): use pre-installed Node.js for system migration test (#145)
1 parent 7411d1a commit 186a15a

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/integration-test-migrate-node-ubuntu-system.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,13 @@ jobs:
3434
echo "$HOME/.dtvem/shims" >> $GITHUB_PATH
3535
echo "$HOME/.dtvem/bin" >> $GITHUB_PATH
3636
37-
- name: "Install Node.js 18.x via apt (NodeSource)"
37+
- name: "Verify pre-installed Node.js"
3838
run: |
39-
curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash -
40-
sudo apt-get install -y nodejs
4139
echo "System Node.js installed at: $(which node)"
4240
node --version
41+
# Capture the version for later verification
42+
NODE_VERSION=$(node --version | sed 's/v//')
43+
echo "NODE_VERSION=$NODE_VERSION" >> $GITHUB_ENV
4344
4445
- name: "Migrate system Node.js to dtvem"
4546
run: |
@@ -51,17 +52,17 @@ jobs:
5152
5253
- name: "Verify migrated version"
5354
run: |
54-
# Check that we have a version starting with 18
55-
./dist/dtvem list node | grep -E "18\." || (echo "ERROR: Expected Node.js 18.x to be migrated" && exit 1)
56-
echo "SUCCESS: Node.js 18.x was migrated from system"
55+
# Check that we have the same version that was pre-installed
56+
./dist/dtvem list node | grep -F "$NODE_VERSION" || (echo "ERROR: Expected Node.js $NODE_VERSION to be migrated" && exit 1)
57+
echo "SUCCESS: Node.js $NODE_VERSION was migrated from system"
5758
5859
- name: Generate summary
5960
if: always()
6061
run: |
6162
echo "## Node.js Migration from System (Ubuntu)" >> $GITHUB_STEP_SUMMARY
6263
echo "" >> $GITHUB_STEP_SUMMARY
63-
echo "**Source:** apt (NodeSource)" >> $GITHUB_STEP_SUMMARY
64-
echo "**Version:** 18.x" >> $GITHUB_STEP_SUMMARY
64+
echo "**Source:** Pre-installed system Node.js" >> $GITHUB_STEP_SUMMARY
65+
echo "**Version:** $NODE_VERSION" >> $GITHUB_STEP_SUMMARY
6566
echo "" >> $GITHUB_STEP_SUMMARY
6667
echo "### Installed Versions" >> $GITHUB_STEP_SUMMARY
6768
echo '```' >> $GITHUB_STEP_SUMMARY

0 commit comments

Comments
 (0)