Skip to content

Commit 261a240

Browse files
committed
fix(path): address lint errors in path_windows.go
- Add pathActionAdd constant to fix goconst warning - Fix "cancelled" -> "canceled" spelling (American English)
1 parent 1a86f22 commit 261a240

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

src/internal/path/path_windows.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ const (
3030

3131
// pathActionMove is used to indicate the shims directory needs to be moved to the beginning of PATH
3232
pathActionMove = "move"
33+
// pathActionAdd is used to indicate the shims directory needs to be added to PATH
34+
pathActionAdd = "add"
3335
)
3436

3537
// RuntimeConflict represents a system-installed runtime that may conflict with dtvem
@@ -132,7 +134,7 @@ func checkSystemPath(shimsDir string) (bool, string, error) {
132134
} else if foundAt > 0 {
133135
return true, pathActionMove, nil // Exists but not at beginning
134136
}
135-
return true, "add", nil // Not in PATH
137+
return true, pathActionAdd, nil // Not in PATH
136138
}
137139

138140
// checkUserPath checks if the shims directory needs to be added/moved in User PATH
@@ -151,7 +153,7 @@ func checkUserPath(shimsDir string) (bool, string, error) {
151153

152154
// If PATH doesn't exist yet, we need to add it
153155
if errors.Is(err, registry.ErrNotExist) || currentPath == "" {
154-
return true, "add", nil
156+
return true, pathActionAdd, nil
155157
}
156158

157159
paths := strings.Split(currentPath, ";")
@@ -170,7 +172,7 @@ func checkUserPath(shimsDir string) (bool, string, error) {
170172
} else if foundAt > 0 {
171173
return true, pathActionMove, nil // Exists but not at beginning
172174
}
173-
return true, "add", nil // Not in PATH
175+
return true, pathActionAdd, nil // Not in PATH
174176
}
175177

176178
// isAdmin checks if the current process has administrator privileges
@@ -471,7 +473,7 @@ func warnAboutSystemConflicts(conflicts []RuntimeConflict, skipConfirmation bool
471473
return true, nil
472474
}
473475

474-
ui.Info("User install cancelled. Run 'dtvem init' without --user for system-level PATH.")
476+
ui.Info("User install canceled. Run 'dtvem init' without --user for system-level PATH.")
475477
return false, nil
476478
}
477479

0 commit comments

Comments
 (0)