Skip to content

Commit 52cc30c

Browse files
committed
chore(release): fix changelog generation order
Move changelog generation step before tag creation so that git describe finds the previous release tag instead of the newly created one. Fixes #63
1 parent 831a6c3 commit 52cc30c

1 file changed

Lines changed: 18 additions & 16 deletions

File tree

.github/workflows/release.yml

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -248,26 +248,12 @@ jobs:
248248
name: install-scripts
249249
path: .
250250

251-
- name: Create and push release tag
252-
run: |
253-
VERSION="${{ github.event.inputs.version }}"
254-
git config user.name "github-actions[bot]"
255-
git config user.email "github-actions[bot]@users.noreply.github.com"
256-
257-
# Create tag on current commit (version files are not committed back to main)
258-
# The version updates exist only in the build artifacts, not in source
259-
git tag -a "v$VERSION" -m "Release v$VERSION"
260-
git push origin "v$VERSION"
261-
echo "✓ Created and pushed tag v$VERSION"
262-
echo ""
263-
echo "Note: Version remains 'dev' in main branch source code"
264-
echo "Released binaries and install scripts contain version $VERSION"
265-
shell: bash
266-
267251
- name: Generate changelog
268252
id: changelog
269253
run: |
270254
# Get commits since last release tag
255+
# NOTE: This must run BEFORE creating the new tag, otherwise git describe
256+
# will find the new tag and the changelog will be empty
271257
PREVIOUS_TAG=$(git describe --abbrev=0 --tags --match "v*" 2>/dev/null || echo "")
272258
if [ -z "$PREVIOUS_TAG" ]; then
273259
# First release - get all commits
@@ -287,6 +273,22 @@ jobs:
287273
echo "EOF" >> $GITHUB_OUTPUT
288274
shell: bash
289275

276+
- name: Create and push release tag
277+
run: |
278+
VERSION="${{ github.event.inputs.version }}"
279+
git config user.name "github-actions[bot]"
280+
git config user.email "github-actions[bot]@users.noreply.github.com"
281+
282+
# Create tag on current commit (version files are not committed back to main)
283+
# The version updates exist only in the build artifacts, not in source
284+
git tag -a "v$VERSION" -m "Release v$VERSION"
285+
git push origin "v$VERSION"
286+
echo "✓ Created and pushed tag v$VERSION"
287+
echo ""
288+
echo "Note: Version remains 'dev' in main branch source code"
289+
echo "Released binaries and install scripts contain version $VERSION"
290+
shell: bash
291+
290292
- name: Create GitHub Release
291293
uses: softprops/action-gh-release@v1
292294
with:

0 commit comments

Comments
 (0)