Skip to content

Commit 584bae7

Browse files
committed
fix(ci): check full list-all output for version verification
The verification was checking against the first page of results, but the versions might not be on the first page. Now fetches the full list separately for verification.
1 parent e9daa3e commit 584bae7

3 files changed

Lines changed: 21 additions & 27 deletions

File tree

.github/workflows/integration-test-node.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -108,23 +108,21 @@ jobs:
108108
cd "$TEST_WORKSPACE"
109109
echo "## Node.js Available Versions" >> $GITHUB_STEP_SUMMARY
110110
echo '```' >> $GITHUB_STEP_SUMMARY
111-
AVAILABLE=$(./dtvem${{ matrix.ext }} list-all node)
112-
echo "$AVAILABLE" | head -20 >> $GITHUB_STEP_SUMMARY || true
111+
./dtvem${{ matrix.ext }} list-all node | head -20 >> $GITHUB_STEP_SUMMARY || true
113112
echo '```' >> $GITHUB_STEP_SUMMARY
114113
echo "" >> $GITHUB_STEP_SUMMARY
115114
116-
# Verify test versions are available
115+
# Verify test versions are available (check full output, not just displayed portion)
117116
echo "Verifying test versions are available..."
118-
if ! echo "$AVAILABLE" | grep -q "${{ matrix.version1 }}"; then
117+
FULL_LIST=$(./dtvem${{ matrix.ext }} list-all node 2>/dev/null || true)
118+
if ! echo "$FULL_LIST" | grep -qF "${{ matrix.version1 }}"; then
119119
echo "ERROR: Version ${{ matrix.version1 }} not found in available versions"
120-
echo "Available versions:"
121-
echo "$AVAILABLE"
120+
echo "Searched in $(echo "$FULL_LIST" | wc -l) versions"
122121
exit 1
123122
fi
124-
if ! echo "$AVAILABLE" | grep -q "${{ matrix.version2 }}"; then
123+
if ! echo "$FULL_LIST" | grep -qF "${{ matrix.version2 }}"; then
125124
echo "ERROR: Version ${{ matrix.version2 }} not found in available versions"
126-
echo "Available versions:"
127-
echo "$AVAILABLE"
125+
echo "Searched in $(echo "$FULL_LIST" | wc -l) versions"
128126
exit 1
129127
fi
130128
echo "✓ Both versions ${{ matrix.version1 }} and ${{ matrix.version2 }} are available"

.github/workflows/integration-test-python.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,23 +109,21 @@ jobs:
109109
cd "$TEST_WORKSPACE"
110110
echo "## Python Available Versions" >> $GITHUB_STEP_SUMMARY
111111
echo '```' >> $GITHUB_STEP_SUMMARY
112-
AVAILABLE=$(./dtvem${{ matrix.ext }} list-all python)
113-
echo "$AVAILABLE" | head -20 >> $GITHUB_STEP_SUMMARY || true
112+
./dtvem${{ matrix.ext }} list-all python | head -20 >> $GITHUB_STEP_SUMMARY || true
114113
echo '```' >> $GITHUB_STEP_SUMMARY
115114
echo "" >> $GITHUB_STEP_SUMMARY
116115
117-
# Verify test versions are available
116+
# Verify test versions are available (check full output, not just displayed portion)
118117
echo "Verifying test versions are available..."
119-
if ! echo "$AVAILABLE" | grep -q "${{ matrix.version1 }}"; then
118+
FULL_LIST=$(./dtvem${{ matrix.ext }} list-all python 2>/dev/null || true)
119+
if ! echo "$FULL_LIST" | grep -qF "${{ matrix.version1 }}"; then
120120
echo "ERROR: Version ${{ matrix.version1 }} not found in available versions"
121-
echo "Available versions:"
122-
echo "$AVAILABLE"
121+
echo "Searched in $(echo "$FULL_LIST" | wc -l) versions"
123122
exit 1
124123
fi
125-
if ! echo "$AVAILABLE" | grep -q "${{ matrix.version2 }}"; then
124+
if ! echo "$FULL_LIST" | grep -qF "${{ matrix.version2 }}"; then
126125
echo "ERROR: Version ${{ matrix.version2 }} not found in available versions"
127-
echo "Available versions:"
128-
echo "$AVAILABLE"
126+
echo "Searched in $(echo "$FULL_LIST" | wc -l) versions"
129127
exit 1
130128
fi
131129
echo "✓ Both versions ${{ matrix.version1 }} and ${{ matrix.version2 }} are available"

.github/workflows/integration-test-ruby.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,23 +109,21 @@ jobs:
109109
cd "$TEST_WORKSPACE"
110110
echo "## Ruby Available Versions" >> $GITHUB_STEP_SUMMARY
111111
echo '```' >> $GITHUB_STEP_SUMMARY
112-
AVAILABLE=$(./dtvem${{ matrix.ext }} list-all ruby)
113-
echo "$AVAILABLE" | head -20 >> $GITHUB_STEP_SUMMARY || true
112+
./dtvem${{ matrix.ext }} list-all ruby | head -20 >> $GITHUB_STEP_SUMMARY || true
114113
echo '```' >> $GITHUB_STEP_SUMMARY
115114
echo "" >> $GITHUB_STEP_SUMMARY
116115
117-
# Verify test versions are available
116+
# Verify test versions are available (check full output, not just displayed portion)
118117
echo "Verifying test versions are available..."
119-
if ! echo "$AVAILABLE" | grep -q "${{ matrix.version1 }}"; then
118+
FULL_LIST=$(./dtvem${{ matrix.ext }} list-all ruby 2>/dev/null || true)
119+
if ! echo "$FULL_LIST" | grep -qF "${{ matrix.version1 }}"; then
120120
echo "ERROR: Version ${{ matrix.version1 }} not found in available versions"
121-
echo "Available versions:"
122-
echo "$AVAILABLE"
121+
echo "Searched in $(echo "$FULL_LIST" | wc -l) versions"
123122
exit 1
124123
fi
125-
if ! echo "$AVAILABLE" | grep -q "${{ matrix.version2 }}"; then
124+
if ! echo "$FULL_LIST" | grep -qF "${{ matrix.version2 }}"; then
126125
echo "ERROR: Version ${{ matrix.version2 }} not found in available versions"
127-
echo "Available versions:"
128-
echo "$AVAILABLE"
126+
echo "Searched in $(echo "$FULL_LIST" | wc -l) versions"
129127
exit 1
130128
fi
131129
echo "✓ Both versions ${{ matrix.version1 }} and ${{ matrix.version2 }} are available"

0 commit comments

Comments
 (0)