refactor(runtime): remove hardcoded system paths from DetectInstalled#127
Merged
Merged
Conversation
Remove redundant hardcoded installation paths from all three runtime providers. These paths are redundant because: 1. If the install is in PATH, LookPathExcludingShims() already finds it 2. If the install is NOT in PATH, it's not usable anyway Removed functions: - getNodeInstallLocations() from Node.js provider - getPythonInstallLocations() from Python provider - getRubyInstallLocations() from Ruby provider This simplifies the code and removes maintenance burden of keeping hardcoded paths up to date with new runtime versions. Closes #124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DetectInstalled()to only use PATH detection and version manager detectionRemoved Functions
getNodeInstallLocations()getPythonInstallLocations()getRubyInstallLocations()Rationale
These hardcoded paths were redundant because:
LookPathExcludingShims()already finds itThe hardcoded paths also had maintenance problems:
Test plan
DetectInstalled()still detects:Closes #124