fix(ci): remove conflicting update-manifests workflow#172
Merged
Conversation
The `update-manifests.yml` workflow was creating PRs that conflicted with the R2-based manifest system. Problems with the removed workflow: 1. Skipped versions when SHASUMS256.txt couldn't be fetched upstream, causing loss of 117+ Node.js versions (820 found → 703 generated) 2. Removed `sha256_source` tracking field 3. Pointed URLs to upstream instead of our controlled builds.dtvem.io mirror The correct workflow is `generate-manifests-from-r2.yml` which reads from our R2-hosted binaries and properly handles checksums for all versions. Removed: - .github/workflows/update-manifests.yml - scripts/generate-manifests/ directory - manifest:* npm scripts from package.json
Contributor
Author
|
/skip-changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update-manifests.ymlworkflow that was conflicting with the R2-based manifest systemscripts/generate-manifests/directory (no longer needed)manifest:*npm scripts from package.jsonProblem
The
update-manifests.ymlworkflow was creating PRs (like #171) that:SHASUMS256.txtfrom upstream (820 releases found → only 703 in generated manifest)sha256_sourcetracking - This field indicates where checksums came frombuilds.dtvem.iomirrorSolution
The correct workflow is
generate-manifests-from-r2.ymlwhich:sha256_sourcetrackingbuilds.dtvem.ioURLsRelated: Closed #171