refactor(shim): implement lite ShimProvider interface#75
Merged
Conversation
Introduce ShimProvider interface with minimal methods needed by the shim, allowing Go's linker to eliminate unused code (net/http, progressbar, etc). Changes: - Add ShimProvider interface (Name, DisplayName, Shims, ExecutablePath, IsInstalled, ShouldReshimAfter) - Provider now embeds ShimProvider - Shim uses ShimProvider instead of full Provider - Remove auto-install from shim (show install command instead) - Add GetShimProvider/GetAllShimProviders registry functions - Update README and CONTRIBUTING docs Result: Shim binary reduced from ~10MB to ~4.5MB (56% smaller) Fixes #74
Contributor
Author
|
/release-note Shim binary dropped 56% in this release, and it is much faster! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
ShimProviderinterface with minimal methods needed by the shim binary, allowing Go's linker to eliminate unused code (net/http,progressbar, etc).Changes
ShimProviderinterface with 6 methods:Name,DisplayName,Shims,ExecutablePath,IsInstalled,ShouldReshimAfterProviderinterface now embedsShimProviderShimProviderinstead of fullProviderGetShimProvider()andGetAllShimProviders()registry functionsImpact
net/httpin shimprogressbarin shimBehavior Change
When a configured version is not installed, the shim now shows:
Instead of prompting to install interactively.
Test plan
Fixes #74