Skip to content

refactor(ci): move /release-note from issue to PR body #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CalvinAllen merged 2 commits into from
Dec 10, 2025
Merged

refactor(ci): move /release-note from issue to PR body #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa6394
refactor(ci): move /release-note from issue to PR comments
CalvinAllen Dec 10, 2025
a650738
chore(ci): skip build for changelog workflow changes
CalvinAllen Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ on:
- 'assets/**'
- 'schemas/**'
- '.github/ISSUE_TEMPLATE/**'
- '.github/workflows/generate-changelog.yml'
- '.github/workflows/preview-changelog.yml'
- '.idea/**'
- '.claude/**'
- '.gitignore'
Expand All @@ -26,6 +28,8 @@ on:
- 'assets/**'
- 'schemas/**'
- '.github/ISSUE_TEMPLATE/**'
- '.github/workflows/generate-changelog.yml'
- '.github/workflows/preview-changelog.yml'
- '.idea/**'
- '.claude/**'
- '.gitignore'
Expand Down
35 changes: 12 additions & 23 deletions .github/workflows/generate-changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

# Collect all closed issues by tracing commits -> PRs -> issues
declare -A CLOSED_ISSUES # issue_number -> issue_title
declare -A HIGHLIGHTS # issue_number -> highlight message
declare -a HIGHLIGHTS # array of highlight messages

for SHA in $COMMIT_SHAS; do
echo "Processing commit: $SHA"
Expand All @@ -56,6 +56,14 @@ jobs:
if [ -n "$PR_NUMBER" ]; then
echo " Found PR #$PR_NUMBER"

# Check for /release-note in PR comments
PR_COMMENTS=$(gh pr view "$PR_NUMBER" --json comments --jq '.comments[].body' 2>/dev/null || echo "")
RELEASE_NOTE=$(echo "$PR_COMMENTS" | grep "^/release-note " | sed 's|^/release-note ||' | head -1 || echo "")
if [ -n "$RELEASE_NOTE" ]; then
echo " Found /release-note: $RELEASE_NOTE"
HIGHLIGHTS+=("$RELEASE_NOTE")
fi

# Extract issue numbers from PR body (Fixes #XX, Closes #XX, Resolves #XX)
ISSUE_NUMBERS=$(echo "$PR_BODY" | grep -oiE "(fixes|closes|resolves)\s*#[0-9]+" | grep -oE "[0-9]+" || echo "")

Expand All @@ -68,16 +76,6 @@ jobs:

if [ -n "$ISSUE_TITLE" ]; then
CLOSED_ISSUES[$ISSUE_NUM]="$ISSUE_TITLE"

# Check for /release-note comment on the issue
COMMENTS=$(gh issue view "$ISSUE_NUM" --json comments --jq '.comments[].body' 2>/dev/null || echo "")

RELEASE_NOTE=$(echo "$COMMENTS" | grep "^/release-note " | sed 's|^/release-note ||' | head -1 || echo "")

if [ -n "$RELEASE_NOTE" ]; then
echo " Found /release-note: $RELEASE_NOTE"
HIGHLIGHTS[$ISSUE_NUM]="$RELEASE_NOTE"
fi
fi
fi
done
Expand All @@ -99,15 +97,6 @@ jobs:

if [ -n "$ISSUE_TITLE" ]; then
CLOSED_ISSUES[$ISSUE_NUM]="$ISSUE_TITLE"

# Check for /release-note comment
COMMENTS=$(gh issue view "$ISSUE_NUM" --json comments --jq '.comments[].body' 2>/dev/null || echo "")
RELEASE_NOTE=$(echo "$COMMENTS" | grep "^/release-note " | sed 's|^/release-note ||' | head -1 || echo "")

if [ -n "$RELEASE_NOTE" ]; then
echo " Found /release-note: $RELEASE_NOTE"
HIGHLIGHTS[$ISSUE_NUM]="$RELEASE_NOTE"
fi
fi
fi
done
Expand All @@ -116,11 +105,11 @@ jobs:
# Build changelog
CHANGELOG=""

# Add Highlights section if any /release-note comments exist
# Add Highlights section if any /release-note entries exist
if [ ${#HIGHLIGHTS[@]} -gt 0 ]; then
CHANGELOG="### ✨ Highlights"$'\n\n'
for ISSUE_NUM in "${!HIGHLIGHTS[@]}"; do
CHANGELOG="${CHANGELOG}- ${HIGHLIGHTS[$ISSUE_NUM]}"$'\n'
for HIGHLIGHT in "${HIGHLIGHTS[@]}"; do
CHANGELOG="${CHANGELOG}- ${HIGHLIGHT}"$'\n'
done
CHANGELOG="${CHANGELOG}"$'\n'
fi
Expand Down