Replace direct RepoManager use in backup process#6755
Open
Jackenmen wants to merge 1 commit into
Open
Conversation
Jackenmen
added
Type: Enhancement
github-actions
Bot
added
Category: Core - Other Internals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Since we now have an internal Downloader API, it's safer to use it over manually instantiating RepoManager. This will become especially important when we have schema migrations affecting the repo manager, such as in #6750 though there's no reason we shouldn't already be doing it.
Have the changes in this PR been tested?
No