filter out peptides that have inconsistent signal across all cycles#10
Open
rzidan25 wants to merge 3 commits into
Open
filter out peptides that have inconsistent signal across all cycles#10rzidan25 wants to merge 3 commits into
rzidan25 wants to merge 3 commits into
Conversation
Contributor
|
The function called doesn't exist because it hasn't been defined. Please define the function in addition to calling it and return serve! |
rela-v
requested changes
Jul 20, 2026
Contributor
There was a problem hiding this comment.
Specifically line 141 needs the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
#' This function takes in the raw qc_data (before end-point extraction) and checks,
#' for each peptide, what fraction of cycles have Signal >= threshold at the max
#' exposure time. A peptide is kept only if it clears that bar in at least
#'
min_pct_cyclesof cycles, in every sample.#'
#' @param raw_data krsa raw tidy data (qc_data) - must contain SampleName, Peptide,
#' Cycle, ExposureTime, Signal, Group
#' @param threshold signal threshold used to call a peptide "present" in a cycle
#' @param min_pct_cycles minimum proportion (0-1) of cycles a peptide must clear
#' threshold in, within every sample. Default 0.8 (80%)