Skip to content

filter out peptides that have inconsistent signal across all cycles#10

Open
rzidan25 wants to merge 3 commits into
CogDisResLab:mainfrom
rzidan25:filter_incon_peps
Open

filter out peptides that have inconsistent signal across all cycles#10
rzidan25 wants to merge 3 commits into
CogDisResLab:mainfrom
rzidan25:filter_incon_peps

Conversation

@rzidan25

Copy link
Copy Markdown

Pull Request

#' This function takes in the raw qc_data (before end-point extraction) and checks,

#' for each peptide, what fraction of cycles have Signal >= threshold at the max
#' exposure time. A peptide is kept only if it clears that bar in at least
#' min_pct_cycles of cycles, in every sample.
#'
#' @param raw_data krsa raw tidy data (qc_data) - must contain SampleName, Peptide,
#' Cycle, ExposureTime, Signal, Group
#' @param threshold signal threshold used to call a peptide "present" in a cycle
#' @param min_pct_cycles minimum proportion (0-1) of cycles a peptide must clear
#' threshold in, within every sample. Default 0.8 (80%)

@rzidan25
rzidan25 requested a review from rela-v July 17, 2026 14:44
@rela-v

rela-v commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The function called doesn't exist because it hasn't been defined. Please define the function in addition to calling it and return serve!

Comment thread _template.Rmd

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically line 141 needs the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants