Fix linter errors

Author: habedi

docs/CONFIGURATION.md

@@ -25,7 +25,7 @@ Infera supports configuration via environment variables to customize its behavio
   ```bash
   ## Set to 5GB
   export INFERA_CACHE_SIZE_LIMIT=5368709120
-  
+
   ## Set to 500MB
   export INFERA_CACHE_SIZE_LIMIT=524288000
   ```
@@ -96,10 +96,10 @@ Infera supports configuration via environment variables to customize its behavio
   ```bash
   ## Show all messages including debug
   export INFERA_LOG_LEVEL=DEBUG
-  
+
   ## Show only errors
   export INFERA_LOG_LEVEL=ERROR
-  
+
   ## Show informational messages and above
   export INFERA_LOG_LEVEL=INFO
   ```

infera/src/config.rs

@@ -46,6 +46,7 @@ impl LogLevel {
 
 /// Cache eviction strategy
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[allow(clippy::upper_case_acronyms)]
 pub enum CacheEvictionStrategy {
     /// Least Recently Used - evict oldest accessed files first
     LRU,
@@ -76,6 +77,7 @@ pub struct InferaConfig {
     pub cache_size_limit: u64,
 
     /// Whether to enable verbose logging
+    #[allow(dead_code)]
     pub verbose_logging: bool,
 
     /// HTTP request timeout in seconds
@@ -88,6 +90,7 @@ pub struct InferaConfig {
     pub http_retry_delay_ms: u64,
 
     /// Cache eviction strategy
+    #[allow(dead_code)]
     pub cache_eviction_strategy: CacheEvictionStrategy,
 
     /// Logging level

infera/src/engine.rs

@@ -124,7 +124,7 @@ pub(crate) fn run_inference_impl(
     // If model inner dimensions (after the first/batch dim) are all known (>0),
     // validate that the provided `cols` matches their product. This yields clearer errors
     // than deferring to the backend.
-    if model.input_shape.len() >= 1 {
+    if !model.input_shape.is_empty() {
         let inner_dims = &model.input_shape[1..];
         if inner_dims.iter().all(|&d| d > 0) {
             let expected_inner: usize = inner_dims.iter().map(|&d| d as usize).product();

infera/src/http.rs

@@ -5,7 +5,6 @@ use crate::config::{LogLevel, CONFIG};
 use crate::error::InferaError;
 use crate::log;
 use sha2::{Digest, Sha256};
-use std::env;
 use std::fs::{self, File};
 use std::io;
 use std::path::{Path, PathBuf};
@@ -71,15 +70,16 @@ fn get_cached_files_by_access_time() -> Result<Vec<(PathBuf, SystemTime, u64)>,
     }
 
     let mut files = Vec::new();
-    for entry in fs::read_dir(&dir).map_err(|e| InferaError::IoError(e.to_string()))? {
-        if let Ok(entry) = entry {
-            let path = entry.path();
-            if path.is_file() && path.extension().and_then(|s| s.to_str()) == Some("onnx") {
-                if let Ok(metadata) = fs::metadata(&path) {
-                    let accessed = metadata.accessed().unwrap_or_else(|_| SystemTime::now());
-                    let size = metadata.len();
-                    files.push((path, accessed, size));
-                }
+    for entry in fs::read_dir(&dir)
+        .map_err(|e| InferaError::IoError(e.to_string()))?
+        .flatten()
+    {
+        let path = entry.path();
+        if path.is_file() && path.extension().and_then(|s| s.to_str()) == Some("onnx") {
+            if let Ok(metadata) = fs::metadata(&path) {
+                let accessed = metadata.accessed().unwrap_or_else(|_| SystemTime::now());
+                let size = metadata.len();
+                files.push((path, accessed, size));
             }
         }
     }
@@ -127,14 +127,15 @@ pub(crate) fn clear_cache() -> Result<(), InferaError> {
     if !dir.exists() {
         return Ok(());
     }
-    for entry in fs::read_dir(&dir).map_err(|e| InferaError::IoError(e.to_string()))? {
-        if let Ok(entry) = entry {
-            let path = entry.path();
-            if path.is_file() {
-                fs::remove_file(&path).map_err(|e| InferaError::IoError(e.to_string()))?;
-            } else if path.is_dir() {
-                fs::remove_dir_all(&path).map_err(|e| InferaError::IoError(e.to_string()))?;
-            }
+    for entry in fs::read_dir(&dir)
+        .map_err(|e| InferaError::IoError(e.to_string()))?
+        .flatten()
+    {
+        let path = entry.path();
+        if path.is_file() {
+            fs::remove_file(&path).map_err(|e| InferaError::IoError(e.to_string()))?;
+        } else if path.is_dir() {
+            fs::remove_dir_all(&path).map_err(|e| InferaError::IoError(e.to_string()))?;
         }
     }
     Ok(())
@@ -276,6 +277,7 @@ fn download_file(url: &str, dest: &Path, timeout_secs: u64) -> Result<(), Infera
 mod tests {
     use super::*;
     use mockito::Server;
+    use std::env; // moved here: used in tests only
     use std::thread;
     use tiny_http::{Header, Response, Server as TinyServer};
 

infera/src/lib.rs

@@ -2,7 +2,6 @@
 // The public C API layer and module declarations.
 
 use serde_json::json;
-use std::env;
 use std::ffi::{c_char, CStr, CString};
 use std::fs;
 
@@ -326,16 +325,15 @@ pub extern "C" fn infera_get_cache_info() -> *mut c_char {
         let mut file_count = 0usize;
 
         if cache_dir.exists() {
-            for entry in
-                fs::read_dir(&cache_dir).map_err(|e| error::InferaError::IoError(e.to_string()))?
+            for entry in fs::read_dir(&cache_dir)
+                .map_err(|e| error::InferaError::IoError(e.to_string()))?
+                .flatten()
             {
-                if let Ok(entry) = entry {
-                    let path = entry.path();
-                    if path.is_file() && path.extension().and_then(|s| s.to_str()) == Some("onnx") {
-                        if let Ok(metadata) = fs::metadata(&path) {
-                            total_size += metadata.len();
-                            file_count += 1;
-                        }
+                let path = entry.path();
+                if path.is_file() && path.extension().and_then(|s| s.to_str()) == Some("onnx") {
+                    if let Ok(metadata) = fs::metadata(&path) {
+                        total_size += metadata.len();
+                        file_count += 1;
                     }
                 }
             }

test/sql/test_decimal_features.test

@@ -20,4 +20,3 @@ true
 
 statement ok
 select infera_unload_model('linear_dec')
-

test/sql/test_is_model_loaded.test

@@ -33,4 +33,3 @@ query I
 select infera_is_model_loaded('linear')
 ----
 false
-