Skip to content

Preparation work for following feature work#29

Merged
Col-E merged 16 commits into
masterfrom
multi-module-refactor
Apr 14, 2026
Merged

Preparation work for following feature work#29
Col-E merged 16 commits into
masterfrom
multi-module-refactor

Conversation

@Col-E
Copy link
Copy Markdown
Owner

@Col-E Col-E commented Apr 9, 2026

Changes:

  • Migrated dependency and plugin declarations to pull from libs.versions.toml
  • Enabled build caching
  • Broke up the single module setup into multiple modules
    • Updated gradle build files to retain build/staging-repo output for JReleaser while pulling from child modules
    • The demos module is configured to skip publishing, but any following module such as for work regarding Persistence for docking component layouts #13 will be automatically included
  • Bumped Gradle to 9.4.1
  • Bumped Java target to 21, removing the downgrader plugin targeting 17
  • Bumped JavaFX to 21

Addresses:

Col-E added 4 commits April 8, 2026 20:40
JSpecify annotations are type annotations unlike the jarkarta ones, so IntelliJ gets mad when they're not in the new 'correct' place.

Personally I think this looks stupid but its what the Java Lang Spec says is correct so...
@Col-E Col-E added the enhancement New feature or request label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

Unit Test results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 3eddb95. ± Comparison against base commit 2b02b88.

♻️ This comment has been updated with latest results.

@Col-E Col-E changed the title Preparation refactor work for following feature work Preparation work for following feature work Apr 9, 2026
Comment thread CONTRIBUTING.md
@philliplbryant
Copy link
Copy Markdown

philliplbryant commented Apr 9, 2026

To keep commits small and focused on a single change, can you allow/enable the creation of sub-issues to be added to parent issues?

I'm currently envisioning incrementally integrating larger features like #13 (parent issue) using sub-issues such as

@Col-E
Copy link
Copy Markdown
Owner Author

Col-E commented Apr 9, 2026

I dont see anything in the project settings page regarding sub-issues. Seems to be a preview feature, and I dont see it in the preview feature dashboard either.

Comment thread gradle/wrapper/gradle-wrapper.properties
Comment thread build.gradle Outdated
Comment thread CONTRIBUTING.md
@philliplbryant
Copy link
Copy Markdown

I dont see anything in the project settings page regarding sub-issues. Seems to be a preview feature, and I dont see it in the preview feature dashboard either.

If you're interested in enabling sub-issues, go to the repository main page → Settings → under Features make sure Issues is selected. To create a sub-issue, open the parent issue. At the bottom of the issue description click Create sub-issue.

Comment thread settings.gradle
Comment thread demos/build.gradle Outdated
Comment thread settings.gradle
Comment thread demos/build.gradle
Comment thread build.gradle
group = 'software.coley'
version = '0.15.1'
ext.pluginId = { provider -> provider.get().pluginId }

Copy link
Copy Markdown

@philliplbryant philliplbryant Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle recommends using Convention Plugins via an included build instead of allprojects or subprojects.

Copy link
Copy Markdown

@philliplbryant philliplbryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (as if you need my approval ;0) with changes suggested.

@Col-E
Copy link
Copy Markdown
Owner Author

Col-E commented Apr 10, 2026

If you're interested in enabling sub-issues, go to the repository main page → Settings → under Features make sure Issues is selected. To create a sub-issue, open the parent issue. At the bottom of the issue description click Create sub-issue.

Issues are active, you wouldn't be able to make anything otherwise 😂 - And no sub-issue button/link appears on any issue under Bento. Checked that too earlier. Here's the options listed:

image

@philliplbryant
Copy link
Copy Markdown

Issues are active, you wouldn't be able to make anything otherwise 😂 - And no sub-issue button/link appears on any issue under Bento. Checked that too earlier. Here's the options listed:

I didn't pick the UI component names. I didn't see the checkbox initially, but it's there, it's not checked by default, and it's titled Issues.

issues

Maybe it would be better for me to wait until you complete this preparation issue, create a different pull request with the persistence modules, and you can decide whether or not you want them. If you don't, that's fine. We can always maintain the the libraries separately.

@Col-E
Copy link
Copy Markdown
Owner Author

Col-E commented Apr 10, 2026

image

Its been checked by default for every repo I've ever created 🤔

@ianbrandt
Copy link
Copy Markdown

Its been checked by default for every repo I've ever created 🤔

This may be a permissions rather than an enablement issue: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/adding-sub-issues.

Who can use this feature?
People with at least triage permissions for a repository can add sub-issues.

@philliplbryant
Copy link
Copy Markdown

It wasn't intuitive to find, but it did the trick.

sub-issue

Again, if you want me to post the persistence work that I've done, I can do so when and if you're ready. I think it would be best for me to hold off on any further comments/issues until then.

@Col-E
Copy link
Copy Markdown
Owner Author

Col-E commented Apr 10, 2026

People with at least triage permissions for a repository can add sub-issues.

>https://docs.github.com/en/organizations

Ooooooh this is a thing that only affects organization projects. Ok thats why they don't show up here.

@Col-E
Copy link
Copy Markdown
Owner Author

Col-E commented Apr 10, 2026

image

Or... not? Have I really just glossed over this button for the past year or so that sub-issues have been supported for? Maybe I really do need my eyes checked.

To facilitate 'gradlew :demos:{xyz}:run' while retaining no transitive dependency on JavaFX in the output
@ianbrandt
Copy link
Copy Markdown

Or... not? Have I really just glossed over this button for the past year or so that sub-issues have been supported for? Maybe I really do need my eyes checked.

Looking at other personal account repos, I'm only seeing the "Create sub-issue" button on issues when I have the Collaborator role for the repo. I'm guessing for this feature the equivalent of having triage permission for an org repo is having the Collaborator role for a personal repo. That may be why you can see the button as an Owner of this repo, and @philliplbryant can't having not been added as a Collaborator. This action isn't explicitly called out in the docs, but it seems to align with the categories of actions a Collaborator can perform.

@Col-E
Copy link
Copy Markdown
Owner Author

Col-E commented Apr 14, 2026

Going to merge and handle using convention plugins as following cleanup. Everything else is in, and seems to be working as intended.

@Col-E Col-E merged commit ec3fe0e into master Apr 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants