Skip to content

Issue #33: Default to @NonNull values#34

Merged
Col-E merged 6 commits into
Col-E:masterfrom
philliplbryant:enhancement/issue-31
Apr 17, 2026
Merged

Issue #33: Default to @NonNull values#34
Col-E merged 6 commits into
Col-E:masterfrom
philliplbryant:enhancement/issue-31

Conversation

@philliplbryant

@philliplbryant philliplbryant commented Apr 15, 2026

Copy link
Copy Markdown

Sets the default value for all types to be non-null and adds a few missing @Nullable annotations.

Phil Bryant added 4 commits April 15, 2026 14:41
BENTO-18:
35a6393 
* When undocking a `Dockable` to a `DragDropStage`, open the `DragDropStage` at the dropped location.
* When undocking a `Dockable` to a `DragDropStage`, make the `DragDropStage` ownerless.
BENTO-17:
7ae0739 
* Remove unused method.
BENTO-31:
7bf2dc7 
* Set the `core` module o default to `@NonNull` types.
* Remove redundant `@NonNull` and added missing `@Nullable` annotations.
BENTO-31:
eddf3ef 
* Remove change leaked from separate PR.
BENTO-31:
0fdd253 
* Restore missing `@Nullable` and mark additional types according to the change.
philliplbryant
philliplbryant commented Apr 15, 2026
View reviewed changes
Comment thread core/src/main/java/software/coley/bentofx/control/HeaderPane.java
philliplbryant
philliplbryant commented Apr 15, 2026
View reviewed changes
Comment thread core/src/main/java/software/coley/bentofx/dockable/Dockable.java
philliplbryant
philliplbryant commented Apr 15, 2026
View reviewed changes
Comment thread core/src/main/java/software/coley/bentofx/search/DockableVisitor.java
philliplbryant
philliplbryant commented Apr 15, 2026
View reviewed changes
Comment thread core/src/main/java/software/coley/bentofx/util/BentoUtils.java
philliplbryant
philliplbryant commented Apr 15, 2026
View reviewed changes
Comment thread core/src/main/java/module-info.java
philliplbryant
philliplbryant commented Apr 15, 2026
View reviewed changes
Comment thread core/src/main/java/module-info.java Outdated
@philliplbryant philliplbryant changed the title Default to @NonNull values Issue #33: Default to @NonNull values Apr 15, 2026
@Col-E Col-E added the enhancement New feature or request label Apr 16, 2026
BENTO-31:
e0a53df 
* Apply the `open` keyword at the module level.
@Col-E Col-E merged commit 115b406 into Col-E:master Apr 17, 2026
3 checks passed
@Col-E Col-E mentioned this pull request Apr 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Col-E Col-E Col-E left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philliplbryant @Col-E