Skip to content

Commit 5b42803

Browse files
committed
AdobeServerScope Breaks Coldbox
1 parent db84465 commit 5b42803

2 files changed

Lines changed: 21 additions & 18 deletions

File tree

system/Bootstrap.cfc

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -717,36 +717,36 @@ component serializable="false" accessors="true" {
717717
required encoding
718718
){
719719
// Status Codes
720-
getPageContextResponse().setStatus( arguments.statusCode );
720+
getPageContextResponse().setStatus( arguments.statusCode )
721721
// Render the Data Content Type
722722
controller
723723
.getDataMarshaller()
724724
.renderContent(
725-
type = arguments.contentType,
726-
encoding = arguments.encoding,
727-
reset = true
728-
);
729-
return this;
725+
type : arguments.contentType,
726+
encoding : arguments.encoding,
727+
reset : true
728+
)
729+
return this
730730
}
731731

732732
/**
733733
* Locate the application key
734734
*/
735735
private function locateAppKey(){
736736
if ( len( trim( variables.COLDBOX_APP_KEY ) ) ) {
737-
return variables.COLDBOX_APP_KEY;
737+
return variables.COLDBOX_APP_KEY
738738
}
739-
return "cbController";
739+
return "cbController"
740740
}
741741

742742
/**
743743
* Helper method to deal with ACF's overload of the page context response, come on Adobe, get your act together!
744744
*/
745745
private function getPageContextResponse(){
746-
if ( server.keyExists( "coldfusion" ) && server.coldfusion.productName.findNoCase( "ColdFusion" ) ) {
747-
return getPageContext().getResponse().getResponse();
746+
if( server.keyExists( "boxlang" ) || server.keyExists( "lucee" ) ) {
747+
return getPageContext().getResponse()
748748
}
749-
return getPageContext().getResponse();
749+
return getPageContext().getResponse().getResponse()
750750
}
751751

752752
}

tests/resources/BaseIntegrationTest.cfc

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,32 +61,35 @@ component
6161
* @beforeEach
6262
*/
6363
function cleanupColdBoxRequestData(){
64-
structDelete( request, "_lastInvalidEvent" );
64+
structDelete( request, "_lastInvalidEvent" )
6565
structDelete( request, "cbTransientDICache" )
6666
}
6767

6868
function isAdobe(){
69-
return server.keyExists( "coldfusion" ) && server.coldfusion.productName.findNoCase( "ColdFusion" );
69+
if( isLucee() || isBoxLang() ){
70+
return false
71+
}
72+
return server.keyExists( "coldfusion" ) && server.coldfusion.productName.findNoCase( "ColdFusion" )
7073
}
7174

7275
function isLucee(){
73-
return server.keyExists( "lucee" );
76+
return server.keyExists( "lucee" )
7477
}
7578

7679
function isBoxLang(){
77-
return server.keyExists( "boxlang" );
80+
return server.keyExists( "boxlang" )
7881
}
7982

8083
function isLucee6(){
81-
return server.keyExists( "lucee" ) && left( server.lucee.version, 1 ) == 6;
84+
return server.keyExists( "lucee" ) && left( server.lucee.version, 1 ) == 6
8285
}
8386

8487
function noWSDLSupport(){
85-
return isAdobe() || isLucee6() || isBoxLang();
88+
return isAdobe() || isLucee6() || isBoxLang()
8689
}
8790

8891
function shutdownColdBox(){
89-
getColdBoxVirtualApp().shutdown();
92+
getColdBoxVirtualApp().shutdown()
9093
}
9194

9295
}

0 commit comments

Comments
 (0)