Fix module settings param for Lucee 6 - COLDBOX-1385#650
Fix module settings param for Lucee 6 - COLDBOX-1385#650michaelborn wants to merge 1 commit intoColdBox:developmentfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a Lucee 6 parsing incompatibility in ModuleService when ensuring a nested moduleSettings struct exists for a module namespace.
Changes:
- Replaces
param name="globalModuleSettings[ ... ]"usage with an explicitkeyExists()check and initialization. - Preserves the existing behavior of merging global module settings into module config settings.
| .getSetting( "ColdBoxConfig" ) | ||
| .getPropertyMixin( "moduleSettings", "variables", {} ); | ||
| param name="globalModuleSettings[ mConfig.modelNamespace ]" default="#structNew()#"; | ||
| if( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) { |
There was a problem hiding this comment.
Spacing around the if condition is inconsistent with the rest of this file (which uses if ( ... )). Please format this as if ( ... ) for consistency/readability.
| if( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) { | |
| if ( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) { |
|
I don't want to change something that has worked since the Adobe 2018 days. This is a Lucee regression and must be reported to them |
|
I wrote this up here: https://luceeserver.atlassian.net/browse/LDEV-6287 But it turns out this is actually due to Lucee 6 limiting evaluation features under the new In short, we'll need to warn developers one of two things:
|
Description
Lucee 6.2.5+48 does not like this syntax in coldbox's ModuleService:
Jira Issues
https://ortussolutions.atlassian.net/browse/COLDBOX-1385
Type of change
Please delete options that are not relevant.
Checklist