-
Notifications
You must be signed in to change notification settings - Fork 268
feat(github) - Authenticate By Organization Membership #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scottwater
wants to merge
9
commits into
ColeMurray:main
Choose a base branch
from
scottwater:github-organizations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bf3467b
build: add GitHub org access configuration
scottwater b77b8f8
feat: allow GitHub organization members to sign in
scottwater 7b81461
docs: document GitHub organization access control
scottwater c31d15d
fix: request read:org only for org allowlists
scottwater f28f20b
fix: add GitHub org membership diagnostics
scottwater 64a4471
ci: pass GitHub org allowlist to Terraform
scottwater 07a834b
docs: clarify GitHub org access rollout
scottwater ac396b6
test: cover GitHub org auth boundary
scottwater 8f01c4a
fix: distinguish unavailable GitHub org checks
scottwater File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Automated Review] M4 (MEDIUM) — OR semantics is a footgun; needs a bold callout
The current phrasing ("If
ALLOWED_USERS,ALLOWED_EMAIL_DOMAINS, andALLOWED_GITHUB_ORGSare all empty, sign-in is denied unlessUNSAFE_ALLOW_ALL_USERS=true") doesn't make the union semantics obvious.A reasonable operator instinct is AND: they set
ALLOWED_EMAIL_DOMAINS=acme.comANDALLOWED_GITHUB_ORGS=acmeexpecting "must be in the org AND on the corp domain." In reality they get a union — a GitHub account with an unverifiedsomeone@acme.comprimary email (see M5) passes via the weaker email check and never reaches the server-enforced org check.Suggested addition: a bold callout near this block: "⚠️ These lists are OR-combined. Configuring multiple allowlists widens access, not narrows it. Each list adds an independent way to be granted access." Same callout belongs in
packages/web/.env.exampleanddocs/GETTING_STARTED.md.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
07a834b.The docs now explicitly call out that allowlists use OR semantics: matching any configured GitHub
username, email domain, or active GitHub org membership grants access. This is documented in:
docs/GETTING_STARTED.mdpackages/web/README.mdpackages/web/.env.exampledocs/SETUP_GUIDE.mdterraform/environments/production/terraform.tfvars.example