FEAT - Add initial implementation of device code flow#90
Open
da1910 wants to merge 13 commits intoColin-b:developfrom
Open
FEAT - Add initial implementation of device code flow#90da1910 wants to merge 13 commits intoColin-b:developfrom
da1910 wants to merge 13 commits intoColin-b:developfrom
Conversation
Author
|
I've given this a test with Auth0, it seems to do as expected. I can also give it a try with Entra ID, I don't have access to an Okta instance to test against however. |
Author
|
Tested with Entra ID as well, seems to be doing the right thing. I've added unit tests for both. I have also added the option to provide your own callback when the request is received, for uses where the library is integrated into a web-app or similar. |
Co-authored-by: da1910 <12086549+da1910@users.noreply.github.com>
docs: add changelog entry for device code flow support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
This PR adds support for the device code OAuth2 flow as seen in https://datatracker.ietf.org/doc/html/rfc8628
The basic flow is that a user makes a request to the device_code endpoint which returns a device code, a user code and a verification URL. The user then opens the verification URL in a device of their choice and enters the user code.
The client polls the token endpoint, and once the user has authenticated they will receive a token and optionally a refresh token.
It's a work in progress for initial review as I mean to add subclasses for Okta, EntraID and for Auth0, as well as tidying up the tests and adding a changelog entry.