Add display toggle switch#23
Open
danialre wants to merge 2 commits into
Open
Conversation
Owner
|
Awesome! This is a really great idea
My apologies in advance if this takes me a couple of weeks to get reviewed
and merged. I’m mega busy at the real job just now, but I promise as soon
as I’ve got a chance I’ll give this a proper look
All the best!
…--
Colin
colinwaddell.com <https://www.colinwaddell.com>
On Thu, 9 Oct 2025 at 17:13, Danial Ebling ***@***.***> wrote:
Hello,
Thanks for your wonderful project! I just finished building it, and I
found that I wanted to turn the display off at night, without having to SSH
in and stop/start the systemd service. Here are the changes:
- Migrate the GPIO library (used in the loading LED scene) to
gpiozero, which should have better support for future Pis
- Add documentation and GPIO support for a toggle switch (connected to
ground) to enable/disable the display - it really pauses and restarts the
Animator so the script doesn't have to restart
- Tweak some scenes (weather, clock, date, day) to handle the Animator
stopping and starting
- Add a user check to options.disable_hardware_pulsing for users that
choose to run as root - I am using a Zero W and found that it doesn't have
the horsepower without hardware PWM
I'm happy to make further changes/rollbacks as desired. Thanks again!
------------------------------
You can view, comment on, or merge this pull request online at:
#23
Commit Summary
- 9105762
<9105762>
migrate to gpiozero
- 3ac4f46
<3ac4f46>
add switch GPIO for enabling/disabling display, added hooks to
reset/restart scenes
File Changes
(9 files <https://github.com/ColinWaddell/FlightTracker/pull/23/files>)
- *M* README.md
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(13)
- *M* display/__init__.py
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-f903c182129a11ab5e8b539681003fdce9f6165d7f7c870b1f701b48c457aa3b>
(36)
- *M* requirements.txt
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552>
(2)
- *M* scenes/clock.py
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-6f19c93d9ad0360369087ef434c2dfe66794848fc3a7091e7e65e6ad9800bc60>
(2)
- *M* scenes/date.py
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-425ed1e851aad5b370fab4efbff9415dafe6c8b7ffd5f21e79b2774e949b2ee7>
(2)
- *M* scenes/day.py
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-977cb71ff6a8efdb3c991d8f639fd9f2b5636af35c5117acaf297f5783e9f16b>
(2)
- *M* scenes/loadingled.py
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-6e33d290627c0956d18cf737e033038f0551e280cd7eb8cbfc488be8db687eef>
(19)
- *M* scenes/weather.py
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-48a05fc849a355bf927ed4141803200b5a831147c3e0601e87e7b7aebb00bcb1>
(2)
- *M* utilities/animator.py
<https://github.com/ColinWaddell/FlightTracker/pull/23/files#diff-e34e8e59c3c492dfd7fd761d7b55185c9f3a403f1b702dae30fac20742b64f22>
(66)
Patch Links:
- https://github.com/ColinWaddell/FlightTracker/pull/23.patch
- https://github.com/ColinWaddell/FlightTracker/pull/23.diff
—
Reply to this email directly, view it on GitHub
<#23>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAODIBLWDKN32K77FS5CXN33W2CTRAVCNFSM6AAAAACIX5HFV6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGQ4TSNZUGY3DCNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Author
|
No worries! I'm running this already, so if I run into any issues I'll just add more commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for your wonderful project! I just finished building it, and I found that I wanted to turn the display off at night, without having to SSH in and stop/start the systemd service. Here are the changes:
options.disable_hardware_pulsingfor users that choose to run as root - I am using a Zero W and found that it doesn't have the horsepower without hardware PWMI'm happy to make further changes/rollbacks as desired. Thanks again!