Code QA

Author: bagusnl

CollapseLauncher/Classes/GameManagement/ImageBackground/ImageBackgroundManager.Loaders.cs

@@ -20,7 +20,6 @@
 using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
-using Windows.Foundation;
 using Windows.UI;
 // ReSharper disable IdentifierTypo
 // ReSharper disable CheckNamespace

CollapseLauncher/Classes/Helper/JsonConverter/SlashToBackslashConverter.cs

@@ -8,7 +8,7 @@ namespace CollapseLauncher.Helper.JsonConverter
 {
     internal class SlashToBackslashConverter : JsonConverter<string?>
     {
-        public override string? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+        public override string Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
             if (reader.TokenType != JsonTokenType.String)
                 throw new JsonException("Current type token is not a string!");

CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HypLauncherContentApi.cs

@@ -17,7 +17,7 @@ public class HypLauncherContentData
     public HypLauncherContentKind? Content { get; set; }
 }
 
-public class HypLauncherContentKind : HypApiIdentifiable
+public partial class HypLauncherContentKind : HypApiIdentifiable
 {
     [JsonPropertyName("language")]
     [JsonConverter(typeof(EmptyStringAsNullConverter))]

CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HypLauncherGameResourcePackageApi.cs

@@ -24,7 +24,7 @@ public override List<HypResourcesData> List
     } = [];
 }
 
-public class HypResourcesData : HypApiIdentifiable
+public partial class HypResourcesData : HypApiIdentifiable
 {
     [JsonPropertyName("main")]
     public HypResourcePackageData? MainPackage { get; set; }

CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HypLauncherGameResourcePluginApi.cs

@@ -21,7 +21,7 @@ public override List<HypResourcePluginData> List
     } = [];
 }
 
-public class HypResourcePluginData : HypApiIdentifiable
+public partial class HypResourcePluginData : HypApiIdentifiable
 {
     [JsonPropertyName("plugins")]
     public List<HypPluginPackageInfo> Plugins

CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HypLauncherGameResourceSdkApi.cs

@@ -19,7 +19,7 @@ public override List<HypChannelSdkData> List
     } = [];
 }
 
-public class HypChannelSdkData : HypApiIdentifiable
+public partial class HypChannelSdkData : HypApiIdentifiable
 {
     [JsonPropertyName("channel_sdk_pkg")]
     public HypPackageData? SdkPackageDetail { get; set; }

CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HypLauncherGameResourceWpfApi.cs

@@ -16,7 +16,7 @@ public override List<HypWpfPackageData> List
     } = [];
 }
 
-public class HypWpfPackageData : HypApiIdentifiable
+public partial class HypWpfPackageData : HypApiIdentifiable
 {
     [JsonPropertyName("wpf_package")]
     public HypPackageData? PackageInfo { get; set; }

CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HypLauncherSophonBranchesApi.cs

@@ -20,7 +20,7 @@ public override List<HypLauncherSophonBranchesKind> List
     } = [];
 }
 
-public sealed class HypLauncherSophonBranchesKind : HypApiIdentifiable
+public sealed partial class HypLauncherSophonBranchesKind : HypApiIdentifiable
 {
     [JsonPropertyName("main")]
     public HypGameInfoBranchData? GameMainField { get; init; }

CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs

@@ -163,7 +163,7 @@ internal async Task BuildPrimaryManifest(DownloadClient
             // Create fake pkg_version(s) from Sophon and get the list of SphonAsset(s)
             List<SophonAsset> sophonAssetList = [];
             await GenshinInstall.DownloadPkgVersionStatic(httpClient,
-                                                          GameVersionManager!,
+                                                          GameVersionManager,
                                                           GamePath,
                                                           gameAudioListPath,
                                                           manifestMainInfoPair,

CollapseLauncher/XAMLs/MainApp/DisconnectedPage.xaml.cs

@@ -36,7 +36,7 @@ public DisconnectedPage()
 
         private void InitializeRegionComboBox()
         {
-            string? gameTitle = MetadataHelper.GetLastSavedGameTitleOrDefault();
+            var gameTitle = MetadataHelper.GetLastSavedGameTitleOrDefault();
 
             List<string>       gameTitleList  = MetadataHelper.CurrentGameTitleList;
             List<PresetConfig> gameRegionList = MetadataHelper.GetGameRegionList(gameTitle);