Skip to content

Commit 45087c6

Browse files
committed
remove redundant save() call
1 parent 6d6440e commit 45087c6

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

src/main/java/com/taskmanagerapi/service/TaskService.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ public Optional<Task> getTask(String id) {
3737
return taskRepository.findById(id);
3838
}
3939

40-
@Transactional
4140
public Optional<Task> searchTaskByName(String name) {
4241
return taskRepository.findTaskByName(name);
4342
}
@@ -46,32 +45,32 @@ public List<Task> searchTaskByStatus(TaskStatus status) {
4645
return taskRepository.findTasksByStatus(status);
4746
}
4847

48+
@Transactional
4949
public Optional<Task> completeTask(String id) {
5050
return taskRepository.findById(id).map(task -> {
5151
task.setStatus(DONE);
52-
taskRepository.save(task);
5352
return task;
5453
});
5554
}
5655

56+
@Transactional
5757
public Optional<Task> deleteTask(String id) {
5858
return taskRepository.findById(id).map(task -> {
5959
if (task.getStatus() == DELETED) {
6060
logger.info("Task '{}' is already deleted", task.getName());
6161
} else {
6262
task.setStatus(DELETED); // soft delete
63-
taskRepository.save(task);
6463
logger.info("Task '{}' has been deleted", task.getName());
6564
}
6665
return task;
6766
});
6867
}
6968

69+
@Transactional
7070
public Optional<Task> undoDelete(String id) {
7171
return taskRepository.findById(id).map(task -> {
7272
if (task.getStatus() == DELETED) {
7373
task.setStatus(CREATED);
74-
taskRepository.save(task);
7574
logger.info("Task '{}' reactivated", task.getName());
7675
} else {
7776
logger.info("Task '{}' could not be reactivated", task.getName());

0 commit comments

Comments
 (0)