Removed unused constants and updated ctllog/ctx file writes to first write to temp file and switch to minimize file corruption during server issues.

Author: Nathan Lee

pyrunner/core/constants.py

@@ -34,7 +34,4 @@
 HEADER_SHELL  = '#{}\n#ID|PARENT_IDS|MAX_ATTEMPTS|RETRY_WAIT_TIME|PROCESS_NAME|SHELL_COMMAND|LOGFILE'.format(MODE_SHELL)
 HEADER_PYTHON = '#{}\n#ID|PARENT_IDS|MAX_ATTEMPTS|RETRY_WAIT_TIME|PROCESS_NAME|MODULE_NAME|WORKER_NAME|ARGUMENTS|LOGFILE'.format(MODE_PYTHON)
 
-REPOMGR_HOME = os.path.dirname(os.path.realpath(__file__))
-LOCAL_REPO = '{}/repo'.format(REPOMGR_HOME)
-
 ROOT_NODE_NAME = 'PyRunnerRootNode'

pyrunner/core/pyrunner.py

@@ -194,7 +194,12 @@ def save_state(self, suppress_output=False):
 
       if not suppress_output:
         print('Saving Context Object to File: {}'.format(self.config.ctx_file))
-      pickle.dump(state_obj, open(self.config.ctx_file, 'wb'))
+      tmp  = self.config.ctx_file+'.tmp'
+      perm = self.config.ctx_file
+      pickle.dump(state_obj, open(tmp, 'wb'))
+      if os.path.isfile(perm):
+        os.unlink(perm)
+      os.rename(tmp, perm)
 
     except Exception:
       print("Failure in save_context()")

pyrunner/serde/abstract.py

@@ -14,6 +14,7 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
+import os
 from abc import ABCMeta, abstractmethod
 
 class SerDe:
@@ -42,9 +43,15 @@ def deserialize(self, proc_file, restart=False):
     pass
 
   def save_to_file(self, filepath, node_register):
+    tmp  = filepath+'.tmp'
+    perm = filepath
+    
     try:
-      with open(filepath, 'w') as file:
+      with open(tmp, 'w') as file:
         file.write(self.serialize(node_register))
+      if os.path.isfile(perm):
+        os.unlink(perm)
+      os.rename(tmp, perm)
     except Exception:
       print('Failure in save_to_file()')
       raise