Merge branch 'main' into externaldimensions

Author: nstepien

.github/workflows/ci.yml

@@ -38,21 +38,18 @@ jobs:
         run: npx playwright install chromium firefox
 
       - name: Test
-        run: node --run test
+        run: node --run test:ci
         timeout-minutes: 4
 
-      - name: Visual regression test
-        run: node --run visual
-
       - name: Upload test failure artifacts
         if: failure()
         uses: actions/upload-artifact@v7
         with:
           name: test-artifacts
           path: |
-            test/browser/**/__screenshots__/**
-            test/browser/**/__traces__/**
-            .vitest-attachments/test/**/*
+            test/**/__screenshots__/**
+            test/**/__traces__/**
+            .vitest-attachments/test/**
           if-no-files-found: ignore
 
       - name: Upload coverage

.github/workflows/publish.yml

@@ -49,12 +49,9 @@ jobs:
         run: npx playwright install chromium firefox
 
       - name: Test
-        run: node --run test
+        run: node --run test:ci
         timeout-minutes: 4
 
-      - name: Visual regression test
-        run: node --run visual
-
       - name: Update version
         run: |
           git config user.name "${{ github.actor }}"

.github/workflows/update-screenshots.yml

@@ -5,14 +5,6 @@ on:
     types: [labeled]
   workflow_dispatch:
 
-env:
-  AUTHOR_NAME: 'github-actions[bot]'
-  AUTHOR_EMAIL: '41898282+github-actions[bot]@users.noreply.github.com'
-  COMMIT_MESSAGE: |
-    Update screenshots
-
-    Co-authored-by: ${{ github.actor }}
-
 jobs:
   update-screenshots:
     if: ${{ github.event.label.name == 'Update Screenshots' || github.event_name == 'workflow_dispatch' }}
@@ -46,12 +38,12 @@ jobs:
         run: npx playwright install chromium firefox
       - name: Update screenshots
         run: |
-          rm -r test/visual/__screenshots__
-          node --run visual:update
+          rm -r test/**/screenshots/**
+          node --run test:ci:update
       - name: Push new screenshots
         run: |
-          git config --global user.name "${{ env.AUTHOR_NAME }}"
-          git config --global user.email "${{ env.AUTHOR_EMAIL }}"
-          git add test/visual/__screenshots__/.
-          git diff-index --quiet HEAD || git commit -m "${{ env.COMMIT_MESSAGE }}"
+          git config user.name "${{ github.actor }}"
+          git config user.email "${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com"
+          git add "test/**/screenshots/**"
+          git diff-index --quiet HEAD || git commit -m "Update screenshots"
           git push

.gitignore

@@ -1,15 +1,17 @@
 /.cache
 /.claude
-/coverage
 /dist
 /lib
 /node_modules
 /package-lock.json
-test/browser/**/__screenshots__
 
 npm-debug.log
 **.orig
 .idea
-.vitest-attachments
 
-__traces__
+# Vitest
+/.vitest-attachments
+/coverage
+/test/**/__screenshots__
+/test/**/__traces__
+/test/**/screenshots/**/*-win32.png

.vscode/settings.json

@@ -8,8 +8,8 @@
   "editor.defaultFormatter": "oxc.oxc-vscode",
   "editor.formatOnSave": true,
   "editor.formatOnSaveMode": "file",
-  "typescript.enablePromptUseWorkspaceTsdk": true,
-  "typescript.tsdk": "node_modules/typescript/lib",
+  "js/ts.tsdk.promptToUseWorkspaceVersion": true,
+  "js/ts.tsdk.path": "node_modules/typescript/lib",
   "files.readonlyInclude": {
     "**/routeTree.gen.ts": true
   },

AGENTS.md

@@ -55,7 +55,7 @@ website/              # demo site (Vite + TanStack Router)
 - Browser tests use `vitest/browser` + Playwright. `test/setupBrowser.ts` configures `page.render()` via `vitest-browser-react` and registers custom locators via `locators.extend()` — prefer `page.getGrid()`, `page.getCell({ name })`, `page.getRow()`, `page.getHeaderCell()`, `page.getSelectedCell()`, etc. over raw `page.getByRole()`.
 - Test helpers in `test/browser/utils.tsx`: `setup()`, `getRowWithCell()`, `getCellsAtRowIndex()`, `validateCellPosition()`, `scrollGrid()`, `tabIntoGrid()`, `testCount()`, `testRowCount()`.
 - `test/failOnConsole.ts` fails tests on unexpected console warnings/errors.
-- **Never run visual regression tests locally** — screenshots are CI-only and environment-dependent.
+- **Never run visual regression tests** — screenshots are environment-dependent so visual regression tests must run in CI only.
 
 ## Validation
 

eslint.config.js

@@ -917,6 +917,24 @@ copy(
       '@eslint-react/no-create-ref': 0,
 
       // https://github.com/vitest-dev/eslint-plugin-vitest#rules
+      /*
+// copy all the rules from the rules table for easy pasting
+copy(
+  Iterator.from(
+    document
+      // select rules table
+      .querySelector('.markdown-heading:has(> a[href="#rules"]) ~ markdown-accessiblity-table')
+      // select all rows with a rule
+      .querySelectorAll('tr:has(a)')
+  )
+    // filter out deprecated rules
+    .filter((row) => row.lastElementChild.textContent === '')
+    // map row to rule declaration
+    .map((row) => `'vitest/${row.firstElementChild.textContent}': 1,`)
+    .toArray()
+    .join('\n')
+);
+      */
       'vitest/consistent-each-for': 1,
       'vitest/consistent-test-filename': 0,
       'vitest/consistent-test-it': 1,
@@ -931,7 +949,6 @@ copy(
       'vitest/no-conditional-in-test': 0,
       'vitest/no-conditional-tests': 1,
       'vitest/no-disabled-tests': 0,
-      'vitest/no-done-callback': 1,
       'vitest/no-duplicate-hooks': 1,
       'vitest/no-focused-tests': [1, { fixable: false }],
       'vitest/no-hooks': 0,
@@ -943,7 +960,19 @@ copy(
       'vitest/no-mocks-import': 1,
       'vitest/no-restricted-matchers': 0,
       'vitest/no-restricted-vi-methods': 0,
-      'vitest/no-standalone-expect': 1,
+      'vitest/no-standalone-expect': [
+        1,
+        {
+          additionalTestBlockFunctions: [
+            'beforeAll',
+            'beforeEach',
+            'afterAll',
+            'afterEach',
+            'aroundAll',
+            'aroundEach'
+          ]
+        }
+      ],
       'vitest/no-test-prefixes': 1,
       'vitest/no-test-return-statement': 1,
       'vitest/no-unneeded-async-expect-function': 1,
@@ -979,7 +1008,7 @@ copy(
       'vitest/prefer-strict-equal': 1,
       'vitest/prefer-to-be': 1,
       'vitest/prefer-to-be-falsy': 0,
-      'vitest/prefer-to-be-object': 0,
+      'vitest/prefer-to-be-object': 1,
       'vitest/prefer-to-be-truthy': 0,
       'vitest/prefer-to-contain': 1,
       'vitest/prefer-to-have-been-called-times': 1,
@@ -990,7 +1019,8 @@ copy(
       'vitest/require-hook': 0,
       'vitest/require-local-test-context-for-concurrent-snapshots': 0,
       'vitest/require-mock-type-parameters': 0,
-      'vitest/require-to-throw-message': 0,
+      'vitest/require-test-timeout': 0,
+      'vitest/require-to-throw-message': 1,
       'vitest/require-top-level-describe': 0,
       'vitest/valid-describe-callback': 1,
       'vitest/valid-expect': [1, { alwaysAwait: true }],

package.json

@@ -36,57 +36,56 @@
     "preview": "vite preview",
     "build:website": "vite build",
     "build": "rolldown -c",
-    "test": "vitest run --project browser --project node --coverage.reportsDirectory='./coverage/test'",
+    "test": "vitest run --project browser --project node",
     "test:watch": "vitest watch --project browser --project node",
-    "visual": "vitest run --project visual --coverage.reportsDirectory='./coverage/visual'",
-    "visual:update": "vitest run --project visual --update",
+    "test:ci": "vitest run",
+    "test:ci:update": "vitest run --project visual --update",
     "format": "oxfmt",
     "format:check": "oxfmt --check",
     "eslint": "eslint --max-warnings 0 --cache --cache-location .cache/eslint --cache-strategy content",
     "eslint:fix": "node --run eslint -- --fix",
     "typecheck": "tsc --build"
   },
   "devDependencies": {
-    "@eslint-react/eslint-plugin": "3.0.0-rc.0",
+    "@eslint-react/eslint-plugin": "^3.0.0",
     "@eslint/markdown": "^7.5.1",
-    "@faker-js/faker": "^10.0.0",
-    "@tanstack/react-router": "^1.132.31",
-    "@tanstack/router-plugin": "^1.132.31",
-    "@types/node": "^25.0.2",
-    "@types/react": "^19.2.0",
-    "@types/react-dom": "^19.2.0",
-    "@vitejs/plugin-react": "^5.1.1",
-    "@vitest/browser-playwright": "^4.0.16",
-    "@vitest/coverage-istanbul": "^4.0.16",
-    "@vitest/eslint-plugin": "^1.6.4",
+    "@faker-js/faker": "^10.3.0",
+    "@tanstack/react-router": "^1.166.7",
+    "@tanstack/router-plugin": "^1.166.7",
+    "@types/node": "^25.5.0",
+    "@types/react": "^19.2.14",
+    "@types/react-dom": "^19.2.3",
+    "@vitejs/plugin-react": "^6.0.1",
+    "@vitest/browser-playwright": "^4.1.0",
+    "@vitest/coverage-istanbul": "^4.1.0",
+    "@vitest/eslint-plugin": "^1.6.12",
     "clsx": "^2.1.1",
     "ecij": "^0.4.1",
-    "eslint": "^10.0.1",
+    "eslint": "^10.0.3",
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-react-hooks": "^7.0.1",
-    "eslint-plugin-sonarjs": "^4.0.0",
-    "eslint-plugin-testing-library": "^7.13.5",
-    "jspdf": "^4.0.0",
-    "jspdf-autotable": "^5.0.2",
-    "oxfmt": "0.38.0",
+    "eslint-plugin-sonarjs": "^4.0.2",
+    "eslint-plugin-testing-library": "^7.16.0",
+    "jspdf": "^4.2.0",
+    "jspdf-autotable": "^5.0.7",
+    "oxfmt": "0.41.0",
     "playwright": "~1.58.0",
     "postcss": "^8.5.2",
-    "react": "^19.2.1",
-    "react-dom": "^19.2.1",
+    "react": "^19.2.4",
+    "react-dom": "^19.2.4",
     "rolldown": "1.0.0-rc.5",
-    "rolldown-plugin-dts": "^0.22.1",
+    "rolldown-plugin-dts": "^0.22.5",
     "typescript": "~6.0.1-rc",
-    "typescript-eslint": "^8.56.0",
-    "vite": "^8.0.0-beta.16",
-    "vitest": "^4.0.17",
-    "vitest-browser-react": "^2.0.2"
+    "typescript-eslint": "^8.57.0",
+    "vite": "^8.0.0",
+    "vitest": "^4.1.0",
+    "vitest-browser-react": "^2.1.0"
   },
   "peerDependencies": {
     "react": "^19.2",
     "react-dom": "^19.2"
   },
   "overrides": {
-    "typescript": "$typescript",
-    "vite": "$vite"
+    "typescript": "$typescript"
   }
 }

test/browser/column/key.test.ts

@@ -9,5 +9,5 @@ test('key is escaped in query selectors', async () => {
     }
   ];
 
-  await expect(setup({ columns, rows: [] })).resolves.not.toThrowError();
+  await expect(setup({ columns, rows: [] })).resolves.not.toThrow();
 });

test/failOnConsole.ts

@@ -1,30 +1,29 @@
 let consoleErrorOrConsoleWarnWereCalled = false;
 
 beforeAll(() => {
-  // replace instead of mutating `console` to avoid infinite loops
-  globalThis.console = {
-    ...console,
-    error(...params) {
-      consoleErrorOrConsoleWarnWereCalled = true;
-      console.log(...params);
-    },
-    warn(...params) {
-      consoleErrorOrConsoleWarnWereCalled = true;
-      console.log(...params);
-    }
+  console.error = (...params) => {
+    consoleErrorOrConsoleWarnWereCalled = true;
+    console.log(...params);
+  };
+
+  console.warn = (...params) => {
+    consoleErrorOrConsoleWarnWereCalled = true;
+    console.log(...params);
   };
 });
 
-afterEach(() => {
-  // Wait for both the test and `afterEach` hooks to complete to ensure all logs are caught
+afterEach(({ task, signal }) => {
+  // Wait for the test and all `afterEach` hooks to complete to ensure all logs are caught
   onTestFinished(() => {
-    // eslint-disable-next-line vitest/no-standalone-expect
-    expect
-      .soft(
-        consoleErrorOrConsoleWarnWereCalled,
-        'console.error() and/or console.warn() were called during the test'
-      )
-      .toBe(false);
+    // avoid failing test runs twice
+    if (task.result!.state !== 'fail' || signal.aborted) {
+      expect
+        .soft(
+          consoleErrorOrConsoleWarnWereCalled,
+          'errors/warnings were logged to the console during the test'
+        )
+        .toBe(false);
+    }
 
     consoleErrorOrConsoleWarnWereCalled = false;
   });