Run a single test command in CI (#4007)

* Run a single test command in CI

* add link to bug

* cleaner

* test changing screenshot name, screenshot failure, and adding new screenshot

* don't pass a glob string to rm

* remove soft failure

* Update screenshots

Co-authored-by: nstepien

* tweak git config, reset test

* Update screenshots

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: nstepien

.github/workflows/ci.yml

@@ -38,21 +38,18 @@ jobs:
         run: npx playwright install chromium firefox
 
       - name: Test
-        run: node --run test
+        run: node --run test:ci
         timeout-minutes: 4
 
-      - name: Visual regression test
-        run: node --run visual
-
       - name: Upload test failure artifacts
         if: failure()
         uses: actions/upload-artifact@v7
         with:
           name: test-artifacts
           path: |
-            test/browser/**/__screenshots__/**
-            test/browser/**/__traces__/**
-            .vitest-attachments/test/**/*
+            test/**/__screenshots__/**
+            test/**/__traces__/**
+            .vitest-attachments/test/**
           if-no-files-found: ignore
 
       - name: Upload coverage

.github/workflows/publish.yml

@@ -49,12 +49,9 @@ jobs:
         run: npx playwright install chromium firefox
 
       - name: Test
-        run: node --run test
+        run: node --run test:ci
         timeout-minutes: 4
 
-      - name: Visual regression test
-        run: node --run visual
-
       - name: Update version
         run: |
           git config user.name "${{ github.actor }}"

.github/workflows/update-screenshots.yml

@@ -5,14 +5,6 @@ on:
     types: [labeled]
   workflow_dispatch:
 
-env:
-  AUTHOR_NAME: 'github-actions[bot]'
-  AUTHOR_EMAIL: '41898282+github-actions[bot]@users.noreply.github.com'
-  COMMIT_MESSAGE: |
-    Update screenshots
-
-    Co-authored-by: ${{ github.actor }}
-
 jobs:
   update-screenshots:
     if: ${{ github.event.label.name == 'Update Screenshots' || github.event_name == 'workflow_dispatch' }}
@@ -46,12 +38,12 @@ jobs:
         run: npx playwright install chromium firefox
       - name: Update screenshots
         run: |
-          rm -r test/visual/__screenshots__
-          node --run visual:update
+          rm -r test/**/screenshots/**
+          node --run test:ci:update
       - name: Push new screenshots
         run: |
-          git config --global user.name "${{ env.AUTHOR_NAME }}"
-          git config --global user.email "${{ env.AUTHOR_EMAIL }}"
-          git add test/visual/__screenshots__/.
-          git diff-index --quiet HEAD || git commit -m "${{ env.COMMIT_MESSAGE }}"
+          git config user.name "${{ github.actor }}"
+          git config user.email "${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com"
+          git add "test/**/screenshots/**"
+          git diff-index --quiet HEAD || git commit -m "Update screenshots"
           git push

.gitignore

@@ -1,15 +1,17 @@
 /.cache
 /.claude
-/coverage
 /dist
 /lib
 /node_modules
 /package-lock.json
-test/browser/**/__screenshots__
 
 npm-debug.log
 **.orig
 .idea
-.vitest-attachments
 
-__traces__
+# Vitest
+/.vitest-attachments
+/coverage
+/test/**/__screenshots__
+/test/**/__traces__
+/test/**/screenshots/**/*-win32.png

AGENTS.md

@@ -55,7 +55,7 @@ website/              # demo site (Vite + TanStack Router)
 - Browser tests use `vitest/browser` + Playwright. `test/setupBrowser.ts` configures `page.render()` via `vitest-browser-react` and registers custom locators via `locators.extend()` — prefer `page.getGrid()`, `page.getCell({ name })`, `page.getRow()`, `page.getHeaderCell()`, `page.getSelectedCell()`, etc. over raw `page.getByRole()`.
 - Test helpers in `test/browser/utils.tsx`: `setup()`, `getRowWithCell()`, `getCellsAtRowIndex()`, `validateCellPosition()`, `scrollGrid()`, `tabIntoGrid()`, `testCount()`, `testRowCount()`.
 - `test/failOnConsole.ts` fails tests on unexpected console warnings/errors.
-- **Never run visual regression tests locally** — screenshots are CI-only and environment-dependent.
+- **Never run visual regression tests** — screenshots are environment-dependent so visual regression tests must run in CI only.
 
 ## Validation
 

package.json

@@ -36,10 +36,10 @@
     "preview": "vite preview",
     "build:website": "vite build",
     "build": "rolldown -c",
-    "test": "vitest run --project browser --project node --coverage.reportsDirectory='./coverage/test'",
+    "test": "vitest run --project browser --project node",
     "test:watch": "vitest watch --project browser --project node",
-    "visual": "vitest run --project visual --coverage.reportsDirectory='./coverage/visual'",
-    "visual:update": "vitest run --project visual --update",
+    "test:ci": "vitest run",
+    "test:ci:update": "vitest run --project visual --update",
     "format": "oxfmt",
     "format:check": "oxfmt --check",
     "eslint": "eslint --max-warnings 0 --cache --cache-location .cache/eslint --cache-strategy content",