discardOnRowChange -> closeOnExternalRowChange

Author: amanmahajan7

src/DataGrid.tsx

@@ -904,7 +904,7 @@ export function DataGrid<R, SR = unknown, K extends Key = Key>(props: DataGridPr
     const { idx, row } = selectedPosition;
     const column = columns[idx];
     const colSpan = getColSpan(column, lastFrozenColumnIndex, { type: 'ROW', row });
-    const discardOnRowChange = column.editorOptions?.discardOnRowChange !== false;
+    const closeOnExternalRowChange = column.editorOptions?.closeOnExternalRowChange ?? true;
 
     const closeEditor = (shouldFocusCell: boolean) => {
       setShouldFocusCell(shouldFocusCell);
@@ -926,7 +926,10 @@ export function DataGrid<R, SR = unknown, K extends Key = Key>(props: DataGridPr
       }
     };
 
-    if (discardOnRowChange && rows[selectedPosition.rowIdx] !== selectedPosition.originalRow) {
+    if (
+      closeOnExternalRowChange &&
+      rows[selectedPosition.rowIdx] !== selectedPosition.originalRow
+    ) {
       // Discard changes if rows are updated from outside
       closeEditor(false);
     }

src/EditCell.tsx

@@ -57,7 +57,7 @@ export default function EditCell<R, SR>({
   navigate
 }: EditCellProps<R, SR>) {
   const frameRequestRef = useRef<number>(undefined);
-  const commitOnOutsideClick = column.editorOptions?.commitOnOutsideClick !== false;
+  const commitOnOutsideClick = column.editorOptions?.commitOnOutsideClick ?? true;
 
   // We need to prevent the `useEffect` from cleaning up between re-renders,
   // as `onWindowCaptureMouseDown` might otherwise miss valid mousedown events.

src/types.ts

@@ -64,7 +64,7 @@ export interface Column<TRow, TSummaryRow = unknown> {
     /** @default true */
     readonly commitOnOutsideClick?: Maybe<boolean>;
     /** @default true */
-    readonly discardOnRowChange?: Maybe<boolean>;
+    readonly closeOnExternalRowChange?: Maybe<boolean>;
   }>;
 }
 

test/browser/column/renderEditCell.test.tsx

@@ -218,7 +218,7 @@ describe('Editor', () => {
       expect(getCellsAtRowIndex(0)[1]).toHaveTextContent(/^a1bac$/);
     });
 
-    it('should discard when discardOnRowChange is true or undefined and row is changed from outside', async () => {
+    it('should discard when closeOnExternalRowChange is true or undefined and row is changed from outside', async () => {
       page.render(
         <EditorTest
           editorOptions={{
@@ -234,12 +234,12 @@ describe('Editor', () => {
       await expect.element(editor).not.toBeInTheDocument();
     });
 
-    it('should not discard when discardOnRowChange is false and row is changed from outside', async () => {
+    it('should not discard when closeOnExternalRowChange is false and row is changed from outside', async () => {
       page.render(
         <EditorTest
           editorOptions={{
             commitOnOutsideClick: false,
-            discardOnRowChange: false
+            closeOnExternalRowChange: false
           }}
         />
       );