-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Use native copy/paste event handlers #3667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
31eeb9c
Use native copy/paste event handlers
amanmahajan7 403f417
optional types
amanmahajan7 3288bf3
Move celly copying logic outside the grid
amanmahajan7 2eab97f
Rename `onCopy/Paste` -> `onCellCopy/Paste`
amanmahajan7 459b184
Cleanup
amanmahajan7 c9ca094
Merge branch 'main' into am-native-copy-paste
amanmahajan7 a2b9d00
Merge remote-tracking branch 'origin/main' into am-native-copy-paste
amanmahajan7 dd210ea
Fix types
amanmahajan7 86603d4
Tweaks
amanmahajan7 ca2fe20
Fix copy/paste tests
amanmahajan7 6a93f61
Use `userEvent.copy/paste`
amanmahajan7 c77bd40
fix TreeDataGrid tests
amanmahajan7 fe6f445
Tweak tests
amanmahajan7 7566917
Merge branch 'main' into am-native-copy-paste
amanmahajan7 63eb607
Update example
amanmahajan7 3e67ed1
Merge branch 'main' into am-native-copy-paste
amanmahajan7 06f575a
Merge branch 'main' into am-native-copy-paste
amanmahajan7 2fdd738
Add `CellCopyEvent` and `CellPasteEvent` events
amanmahajan7 d7cb222
Merge branch 'main' into am-native-copy-paste
amanmahajan7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add two separate events (
CellCopyEventandCellPasteEvent)?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can do
and export those instead, it'll be safer to extend one or the other in the future.