Setup VRT#3894
Merged
Merged
Conversation
amanmahajan7
commented
Oct 24, 2025
|
|
||
| env: | ||
| AUTHOR_NAME: 'github-actions[bot]' | ||
| AUTHOR_EMAIL: '41898282+github-actions[bot]@users.noreply.github.com' |
Collaborator
Author
There was a problem hiding this comment.
Copied some of the instructions from https://vitest.dev/guide/browser/visual-regression-testing.html#the-update-workflow
| /> | ||
| ); | ||
|
|
||
| await expect(getGrid()).toMatchScreenshot('basic-grid'); |
Collaborator
Author
There was a problem hiding this comment.
We can tweak the match options if needed
https://vitest.dev/guide/browser/visual-regression-testing.html#global-configuration
Co-authored-by: amanmahajan7
Co-authored-by: amanmahajan7
nstepien
reviewed
Oct 24, 2025
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
This reverts commit 6928269.
Co-authored-by: amanmahajan7
nstepien
approved these changes
Oct 27, 2025
amanmahajan7
added a commit
that referenced
this pull request
Oct 27, 2025
This reverts commit fbc541e.
amanmahajan7
added a commit
that referenced
this pull request
Oct 27, 2025
* Initial commit * Fix typo * Fix typo * Move visual folder inside test folder * Use version instead of SHA * eslint fixes * Fix path * Ignore __screenshots__ in the browser folder * Update screenshots Co-authored-by: amanmahajan7 * Update node version * Delete screenshots * Update screenshots Co-authored-by: amanmahajan7 * Try `workflow_dispatch` * delete screenshots * Add `workflow_dispatch:` * Update screenshots Co-authored-by: amanmahajan7 * Remove `workflow_dispatch:` * try to trigger ci workflow * add test * Update screenshots Co-authored-by: nstepien * add permission * Update screenshots Co-authored-by: nstepien * ci: add workflow_dispatch trigger * geren * Update screenshots Co-authored-by: nstepien * add workflow_dispatch there * Remove the color test * Manually delete screenshots for now * Remove directory before generating screenshots * rename screenshots * Fix command * Update screenshots Co-authored-by: amanmahajan7 * Revert name * Update screenshots Co-authored-by: amanmahajan7 * Update .github/workflows/update-screenshots.yml Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * fix viewport * Remove `--set-upstream` * Update screenshots Co-authored-by: amanmahajan7 * Update test/visual/basicGrid.test.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Try gh cli * Revert "Try gh cli" This reverts commit 6928269. * try `gh pr edit` * Remove invalid token * Add env * Update screenshots Co-authored-by: amanmahajan7 * only remove the label if it's a pr build * nit --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicolas Stepien <stepien.nicolas@gmail.com> Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
royue
pushed a commit
to royue/react-data-grid
that referenced
this pull request
Dec 17, 2025
* Initial commit * Fix typo * Fix typo * Move visual folder inside test folder * Use version instead of SHA * eslint fixes * Fix path * Ignore __screenshots__ in the browser folder * Update screenshots Co-authored-by: amanmahajan7 * Update node version * Delete screenshots * Update screenshots Co-authored-by: amanmahajan7 * Try `workflow_dispatch` * delete screenshots * Add `workflow_dispatch:` * Update screenshots Co-authored-by: amanmahajan7 * Remove `workflow_dispatch:` * try to trigger ci workflow * add test * Update screenshots Co-authored-by: nstepien * add permission * Update screenshots Co-authored-by: nstepien * ci: add workflow_dispatch trigger * geren * Update screenshots Co-authored-by: nstepien * add workflow_dispatch there * Remove the color test * Manually delete screenshots for now * Remove directory before generating screenshots * rename screenshots * Fix command * Update screenshots Co-authored-by: amanmahajan7 * Revert name * Update screenshots Co-authored-by: amanmahajan7 * Update .github/workflows/update-screenshots.yml Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * fix viewport * Remove `--set-upstream` * Update screenshots Co-authored-by: amanmahajan7 * Update test/visual/basicGrid.test.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Try gh cli * Revert "Try gh cli" This reverts commit 6928269. * try `gh pr edit` * Remove invalid token * Add env * Update screenshots Co-authored-by: amanmahajan7 * only remove the label if it's a pr build * nit --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicolas Stepien <stepien.nicolas@gmail.com> Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://vitest.dev/guide/browser/visual-regression-testing.html#visual-regression-testing
This PR sets up VRT. We can use
Update Screenshotslabel to update screenshots when needed